Propagate relative_to to dump_to_pickle#3990
Merged
alejoe91 merged 2 commits intoJun 17, 2025
Merged
Conversation
Member
|
Nice catch! I always use the |
alejoe91
approved these changes
Jun 17, 2025
Member
|
bien joué! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't propagate
relative_totodump_to_picklein thedumpmethod. This PR does.The lack of propagation has a few consequences, including the fact that
recording.save_to_folderandanalyzer.save(folder='...')saves different recording info ifpickled (but not ifjsond).Pretty sure it's a bug, but maybe there's a reason for this?
Added a test to check that
pickleing andjsoning are (almost) the same for a saved-then-loaded recording.