Make NumpySorting.from_unit_dict docs and code consistent#4382
Merged
chrishalcrow merged 2 commits intoSpikeInterface:mainfrom Feb 11, 2026
Merged
Make NumpySorting.from_unit_dict docs and code consistent#4382chrishalcrow merged 2 commits intoSpikeInterface:mainfrom
chrishalcrow merged 2 commits intoSpikeInterface:mainfrom
Conversation
Contributor
|
Yes this looks reasonable and clear. I was initially running this function assuming it takes "time" instead of "samples" and realized why it returned wrong result by looking at the function definition. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4375
@pas-calc I think this makes it unambiguous :)
I think it's simple enough for users to do the time to samples conversion externally, without making the function more complex than it should be