Fix return in wrong block in get_extension_class#4446
Merged
Conversation
alejoe91
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug added in #4406 (sorry!)
Bug is: if you've only imported core, then do
analyzer.compute('quality_metrics'),get_extension_classshould import the quality metrics module, then return the quality metrics class. Instead, I introduced a bug and it returnedNone.Can't figure out how to test this, because it's about which extensions are available depending on which modules have been imported. But in the test suite, we don't have much control over which order modules are imported in.