Skip to content

Remove tmp_data_to_save when loading old analyzers#4480

Merged
alejoe91 merged 5 commits intoSpikeInterface:mainfrom
chrishalcrow:backwards-template-metrics-merge
Mar 30, 2026
Merged

Remove tmp_data_to_save when loading old analyzers#4480
alejoe91 merged 5 commits intoSpikeInterface:mainfrom
chrishalcrow:backwards-template-metrics-merge

Conversation

@chrishalcrow
Copy link
Copy Markdown
Member

Fixes #4471, replacing #4473

In this PR, if you load an analyzer from version <0.104, we set the tmp_data_to_save to be empty. This means that when you merge units, they don't try and merge this metadata. Note: if you do analyzer.compute('template_metrics') the new tmp_data_to_save is created.

Loaded a quite-old analyzer and found some more backwards compat parameter bugs. Solve by using get rather than indexing.

@chrishalcrow chrishalcrow changed the title Add empty metadata to template_metrics on load if doesn't exisx Remove tmp_data_to_save when loading old analyzers Mar 30, 2026
@alejoe91 alejoe91 added the metrics Related to metrics module label Mar 30, 2026
@alejoe91 alejoe91 merged commit 8d4af50 into SpikeInterface:main Mar 30, 2026
15 checks passed
alejoe91 pushed a commit to alejoe91/spikeinterface that referenced this pull request Mar 30, 2026
@alejoe91 alejoe91 mentioned this pull request Mar 30, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

metrics Related to metrics module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't add tmp_data_to_save to old merged analyzer

2 participants