Replace int() truncation with shared ms_to_samples() #4484
Merged
alejoe91 merged 1 commit intoSpikeInterface:mainfrom Apr 2, 2026
Merged
Replace int() truncation with shared ms_to_samples() #4484alejoe91 merged 1 commit intoSpikeInterface:mainfrom
alejoe91 merged 1 commit intoSpikeInterface:mainfrom
Conversation
…form/template sample count conversions. Adds ms_to_samples() to core_tools.py using round() instead of int() to prevent ±1 sampleinconsistencies across datasets with nearly identical sampling rates (e.g. 29999 vs 30000 Hz). Adopted across 21 production files and 5 test files for all waveform/template window geometry; non-waveform conversions (margins, exclusion zones, refractory periods) left unchanged.
Member
|
merci |
alejoe91
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Utility for waveform/template sample count conversions. Adds ms_to_samples() to core_tools.py using round() instead of int() to prevent ±1 sampleinconsistencies across datasets with nearly identical sampling rates (e.g. 29999 vs 30000 Hz). Tried to spot int truncation behavior in the codebase with AI and adopted new util across 21 production files and 5 test files for all waveform/template window geometry; non-waveform conversions (margins, exclusion zones, refractory periods) left unchanged.
Fixes issue #4474