Fix numpy and scipy failures on the CI#4534
Merged
h-mayorquin merged 2 commits intoSpikeInterface:mainfrom Apr 20, 2026
Merged
Conversation
alejoe91
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three tests rely on lenient behavior that newer numpy and scipy have since tightened, and this PR adjusts the test code to match what the assertions actually mean. These failures went unnoticed because they only manifest on the Python 3.13 slot of the
Complete testsmatrix, which resolves to numpy 2.4.4 and scipy 1.17.1, while the Python 3.10 and 3.12 slots and the nightly codecov job all resolve to numpy 2.0.2 where the old behavior still holds. It is unclear to me why 3.13 resolves so much higher than 3.10 and 3.12 on the same workflow. Maybe #4515 but unclear.