Implement cache spike vector for phy sorting reader#4579
Open
samuelgarcia wants to merge 3 commits into
Open
Conversation
alejoe91
added
extractors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to implement the spike vector caching for phy reader in a faster way than #4502
@alejoe91 @grahamfindlay : the implementaion of the caching was slow mainly dur the final lexsort which is normaly not need.
Perfs for the file provide by Graham: (400Mspikes 342 units)
read_phy() + sorting.to_spike_vector() + sorting.to_reordered_spike_vector()
I will work in a sperarte PR to improve the select_unit() and caching.
Important note for us: we should reread all the sorting reader and make the same trick when it is necessary.