feat(phase-60): vector and topic quality fixtures (60-03) - #50
Open
RichardHightower wants to merge 1 commit into
Open
feat(phase-60): vector and topic quality fixtures (60-03)#50RichardHightower wants to merge 1 commit into
RichardHightower wants to merge 1 commit into
Conversation
Paraphrase set BM25 cannot solve, --layers bm25|vector|hybrid on the custom harness, and a labelled TopicExtractor clustering artifact behind the README status table. Mock BM25 is token overlap. Mock vector is a committed lexicon plus TF-IDF cosine, not Candle. Mock hybrid is RRF k=60. memory-bench all excludes semantic so the original custom-harness number is not tanked. Committed: BM25 recall@5 = 0.00 (0/16), vector 1.00 (16/16), hybrid 1.00 (16/16); topics purity 1.00 / ARI 1.00 on synthetic TF-IDF.
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 60-03 of v3.2 Prove It (#46). Stacked on #49 (60-01).
A paraphrase set BM25 cannot solve, a
--layers bm25|vector|hybridswitch on the custom harness, and a labelledTopicExtractor::clusterartifact behind the README status table.Honest caveats (do not skip these):
k=60) of those two lists, not liveRouteQuery.--layersis mock-only; CLImemory searchis always hybrid.memory-bench allexcludessemanticsocustom-harness-mock.jsonis not tanked.Committed numbers
benchmarks/results/semantic-bm25.jsonbenchmarks/results/semantic-vector.jsonbenchmarks/results/semantic-hybrid.jsonbenchmarks/results/topics-quality.jsonCloses BENCH-13 / QUAL-01 / QUAL-02 / QUAL-03. Evidence for #40 and #47.
Does not start 60-02 (#39 — maintainer-owned).
Acceptance
semantic_hits_do_not_contain_query_tokens)--layersonsemantic/run/alltopics-quality.jsonfromTopicExtractor::clustercargo test -p memory-topics --libincludes hand-computed purity 8/9 and ARI 4.5/7Test plan
cargo test -p memory-bench --lib(55 passed, including QUAL-01 leak + BM25<0.4 tests)cargo test -p memory-topics --lib(167 passed, includingmetrics+quality)cargo clippy -p memory-bench --all-targets -- -D warningscargo clippy -p memory-topics --lib -- -D warningsrustfmt --checkon the touched cratesFull
task pr-precheckis workspace-wide; same targeted bar as #49.