Stand-in-memory #185
Merged
Stand-in-memory #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unnel-tests # Conflicts: # server/src/test/java/org/spine3/server/stand/StandFunnelShould.java
Stand funnel tests
* simplify naming; * restructure subscription storage on a Stand side; * update unit tests accordingly.
…ested; field mask is invalid.
…ested; field mask is invalid.
…ry-impl # Conflicts: # server/src/main/java/org/spine3/server/stand/Stand.java
* Refactor Stand tests to use Queries utility class.
Stand storage coverage improvement
…on (\n) ? thenA (\n) : elseB`.
…cks; do not ignore the result of this method and use the timestamp returned.
…ns-style validation.
# Conflicts: # server/src/main/java/org/spine3/server/transport/GrpcContainer.java
* avoid comment-based warning suppressions; * avoid method duplication in the public API. * improve JavaDoc formatting and phrasing.
…ng` and explain why.
…or integration testing instead.
Field masks cleanup
Subscription service coverage improvement
alexander-yevsyukov
approved these changes
Oct 12, 2016
Contributor
alexander-yevsyukov
left a comment
alexander-yevsyukov
left a comment
There was a problem hiding this comment.
LGTM. Good job!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing a main read-side concept — Stand.
Stand provides query and subscription API on per-BoundedContext basis, acting as a facade for data retrieval. Being downstream with the Repositories, Stand also stores the latest Aggregate states, making the state fetch much more efficient.
Application interface has been extended with a couple of read-side oriented gRPC services:
Also, the ClientService has been renamed to "CommandService"; its subscription-related methods were moved to the newly introduced SubscriptionService.