Async subscriptions #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l subscription is created
Contributor
Author
|
@dmytro-kashcheiev, FYI. |
Contributor
Author
|
@armiol, PTAL. |
armiol
approved these changes
Jul 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we expose the asynchronous nature of the event and state subscriptions to the user.
Previously, the user received an
EventSubscription<..>/StateSubscription<..>right away after callingpost(..). This, however, does not reflect the reality of subscriptions on the server being created eventually. The returned object used to hide aFuturewhich ought to complete when the subscription reaches the server.Now, the
post(..)and similar methods return not a subscription, but aFuture. This should let the user know that the subscription is not yet "live".This fixes #32.
Also, in this PR we add wrappers with a common interface for
FIlterandCompositeFilter. This allows users to pass a singleFilterintowhere(..). Previously, the users had to wrap the filter intoall([..])manually each time.This fixes #31.