This repository was archived by the owner on Jul 10, 2026. It is now read-only.
Support custom source sets - #4
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
============================================
+ Coverage 93.38% 93.78% +0.40%
+ Complexity 253 249 -4
============================================
Files 43 44 +1
Lines 907 885 -22
Branches 32 33 +1
============================================
- Hits 847 830 -17
+ Misses 55 50 -5
Partials 5 5 |
alexander-yevsyukov
marked this pull request as ready for review
December 2, 2021 18:32
Contributor
Author
|
@armiol, during my absence, if needed, please feel free to pick this PR up. Otherwise, I hope to pick it up on Monday next week. |
dmdashenkov
approved these changes
Dec 3, 2021
dmdashenkov
left a comment
Contributor
There was a problem hiding this comment.
LGTM with a small note.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
tool-baseandconfig.Notable changes:
GenerateJsonParsersaction class introduced. The class encapsulates the code generation logic which was previously implemented as static methods underMcJsPlugin.McJsExtensionwas renamed toMcJsOptions.McJavaOptions).