Revert PR #293 (accidentally merged)#295
Merged
alexander-yevsyukov merged 4 commits intomasterfrom May 8, 2026
Merged
Conversation
3 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Revert of the accidentally merged PR #293, rolling documentation structure and related build metadata back to the pre-merge state (including version/Gradle wrapper adjustments).
Changes:
- Reverts the docs navigation/layout changes and removes the previous
developer/guide pages, restoring docs to the prior structure (incl. moving/adding content under09-developers-guide/and reshaping user docs paths). - Rolls back published version references (
.416→.415) across Gradle/Maven/docs artifacts. - Downgrades the Gradle wrapper config/scripts to the prior version/settings.
Reviewed changes
Copilot reviewed 44 out of 73 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| version.gradle.kts | Rolls back the published Validation version. |
| tests/validator/build.gradle.kts | Updates an internal build comment wording. |
| README.md | Updates README structure/content (TOC + custom validation section). |
| pom.xml | Rolls back project and dependency versions in generated POM. |
| java-bundle/build.gradle.kts | Reverts header metadata (copyright/license URL). |
| gradlew.bat | Reverts Windows wrapper script logic/flow. |
| gradlew | Reverts the referenced Gradle template commit URL. |
| gradle/wrapper/gradle-wrapper.properties | Downgrades Gradle distribution and removes retry settings. |
| gradle-plugin/src/main/kotlin/io/spine/tools/validation/gradle/ValidationSdk.kt | Renames internal constant (infix → prefix) and updates interpolations. |
| docs/go.sum | Removes docs module Go checksum file. |
| docs/go.mod | Removes the site-commons requirement from docs module Go mod. |
| docs/data/docs/validation/2-0-0-snapshot/sidenav.yml | Reverts/reshapes docs side navigation to the prior layout/paths. |
| docs/content/docs/validation/developer/validation-model.md | Removes prior developer guide page. |
| docs/content/docs/validation/developer/testing-strategy.md | Removes prior developer guide page. |
| docs/content/docs/validation/developer/runtime-library.md | Removes prior developer guide page. |
| docs/content/docs/validation/developer/overview-and-audience.md | Removes prior developer guide page. |
| docs/content/docs/validation/developer/key-modules.md | Removes prior developer guide page. |
| docs/content/docs/validation/developer/java-code-generation.md | Removes prior developer guide page. |
| docs/content/docs/validation/developer/extension-points.md | Removes prior developer guide page. |
| docs/content/docs/validation/developer/build-and-release.md | Removes prior developer guide page. |
| docs/content/docs/validation/developer/architecture.md | Removes prior developer guide page. |
| docs/content/docs/validation/developer/adding-a-built-in-option.md | Removes prior developer guide page. |
| docs/content/docs/validation/09-developers-guide/key-modules.md | Adds developer guide “Key modules” page in restored location. |
| docs/content/docs/validation/09-developers-guide/architecture.md | Adds developer guide “Architecture” page in restored location. |
| docs/content/docs/validation/09-developers-guide/_index.md | Adds developer guide section index. |
| docs/content/docs/validation/05-custom-validation/summary.md | Updates “What’s next” links to the restored developer guide location. |
| docs/content/docs/validation/05-custom-validation/register-the-option.md | Adds restored/updated custom validation step page. |
| docs/content/docs/validation/05-custom-validation/pass-to-compiler.md | Updates “What’s next” link to restored developer guide location. |
| docs/content/docs/validation/05-custom-validation/implement-the-view.md | Adds restored/updated custom validation step page. |
| docs/content/docs/validation/05-custom-validation/implement-the-reaction.md | Adds restored/updated custom validation step page. |
| docs/content/docs/validation/05-custom-validation/implement-the-generator.md | Adds restored/updated custom validation step page. |
| docs/content/docs/validation/05-custom-validation/declare-the-option.md | Adds restored/updated custom validation step page. |
| docs/content/docs/validation/05-custom-validation/declare-event-and-view.md | Adds restored/updated custom validation step page. |
| docs/content/docs/validation/05-custom-validation/_index.md | Adds restored/updated custom validation section index. |
| docs/content/docs/validation/04-validators/validator-registry.md | Adds restored/updated validator registry docs page. |
| docs/content/docs/validation/04-validators/implement-a-validator.md | Updates “What’s next” link to restored developer guide location. |
| docs/content/docs/validation/04-validators/_index.md | Minor formatting + updates “What’s next” link to restored developer guide location. |
| docs/content/docs/validation/03-built-in-options/repeated-and-map-fields.md | Adds restored/updated built-in options page. |
| docs/content/docs/validation/03-built-in-options/oneof-fields.md | Fixes capitalization of an internal link label. |
| docs/content/docs/validation/03-built-in-options/message-level-options.md | Adds restored/updated built-in options page. |
| docs/content/docs/validation/03-built-in-options/field-level-options.md | Adds restored/updated built-in options page. |
| docs/content/docs/validation/03-built-in-options/_index.md | Updates source-of-truth link text/formatting. |
| docs/content/docs/validation/02-concepts/options-overview.md | Adds restored/updated concepts page. |
| docs/content/docs/validation/02-concepts/error-messages.md | Adds restored/updated concepts page. |
| docs/content/docs/validation/02-concepts/_index.md | Adds restored/updated concepts section index. |
| docs/content/docs/validation/01-getting-started/generated-code.md | Adds restored/updated getting-started page. |
| docs/content/docs/validation/01-getting-started/first-model.md | Adds restored/updated getting-started page. |
| docs/content/docs/validation/01-getting-started/build-project.md | Adds restored/updated getting-started page. |
| docs/content/docs/validation/01-getting-started/adding-to-build.md | Rolls back plugin version example (.416 → .415). |
| docs/content/docs/validation/01-getting-started/_index.md | Adds restored/updated getting-started section index. |
| docs/content/docs/validation/00-intro/target-audience.md | Adds restored/updated intro page. |
| docs/content/docs/validation/00-intro/philosophy.md | Adds restored/updated intro page. |
| docs/content/docs/validation/00-intro/_index.md | Adjusts intro wording and removes the previous “Why/How it works” block. |
| docs/content/docs/validation/_index.md | Updates top-level docs index links to restored paths. |
| docs/_settings/embed-code.yml | Reverts embed-code configuration (removes extra code paths/includes). |
| docs/_preview/go.sum | Rolls back Hugo module checksum set. |
| docs/_preview/go.mod | Rolls back Hugo module dependency versions/entries. |
| docs/_preview/content/_index.md | Updates preview landing link target to restored intro path. |
| dependencies.md | Rolls back dependency report version stamps and generation timestamps. |
| context/src/main/kotlin/io/spine/tools/validation/ValidationPlugin.kt | Removes trailing comment marker on plugin constructor close. |
| context/src/main/kotlin/io/spine/tools/validation/ErrorPlaceholder.kt | Minor KDoc wording change. |
| CLAUDE.md | Updates the referenced agent TOC path. |
| buildSrc/src/main/kotlin/io/spine/dependency/local/Validation.kt | Rolls back Validation SDK version constant. |
| buildSrc/src/main/kotlin/fat-jar.gradle.kts | Reverts header metadata and adds/exposes an extra exclusion entry. |
| .gitignore | Removes ignore entry for /.claude/worktrees/. |
| .agents/skills/writer/SKILL.md | Reverts writer skill guidance (removes typographic-quote rule block). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+29
to
+30
| - [Architecture](#architecture) | ||
| - [Extending the Library](#extending-the-library) |
Comment on lines
+95
to
+99
| # Adding custom validation | ||
|
|
||
| Users can extend the library by providing custom Protobuf options and code generation logic. | ||
|
|
||
| See the [Custom validation][custom-validation] section | ||
| of the User Guide for details. | ||
| Follow these steps to create a custom option: |
| * The version of the Validation library artifacts. | ||
| */ | ||
| const val version = "2.0.0-SNAPSHOT.415" | ||
| const val version = "2.0.0-SNAPSHOT.414" |
Comment on lines
62
to
66
| <dependency> | ||
| <groupId>io.spine</groupId> | ||
| <artifactId>spine-validation-jvm-runtime</artifactId> | ||
| <version>2.0.0-SNAPSHOT.415</version> | ||
| <version>2.0.0-SNAPSHOT.414</version> | ||
| <scope>compile</scope> |
Comment on lines
4
to
9
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * |
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * http://www.apache.org/licenses/LICENSE-2.0 |
Comment on lines
38
to
42
| * We have the same items in this enum as in `io.spine.validation.RuntimeErrorPlaceholder` | ||
| * in the runtime library, which is exactly as this one. Please keep them in sync. | ||
| * This duplication is done intentionally to prevent clash between the runtime library, | ||
| * which is added to the classpath of the Compiler, and the runtime library, which is part | ||
| * which is added to the classpath of the Compiler and the runtime library, which is part | ||
| * of the Compiler itself because it is a part of Spine. As we complete our migration |
Comment on lines
+29
to
+30
| - [Architecture](#architecture) | ||
| - [Extending the Library](#extending-the-library) |
Comment on lines
+95
to
+99
| # Adding custom validation | ||
|
|
||
| Users can extend the library by providing custom Protobuf options and code generation logic. | ||
|
|
||
| See the [Custom validation][custom-validation] section | ||
| of the User Guide for details. | ||
| Follow these steps to create a custom option: |
| * The version of the Validation library artifacts. | ||
| */ | ||
| const val version = "2.0.0-SNAPSHOT.415" | ||
| const val version = "2.0.0-SNAPSHOT.414" |
Comment on lines
62
to
66
| <dependency> | ||
| <groupId>io.spine</groupId> | ||
| <artifactId>spine-validation-jvm-runtime</artifactId> | ||
| <version>2.0.0-SNAPSHOT.415</version> | ||
| <version>2.0.0-SNAPSHOT.414</version> | ||
| <scope>compile</scope> |
Comment on lines
+81
to
+89
| - page: Developer’s guide | ||
| key: 09-developers-guide | ||
| children: | ||
| - page: Developer’s guide | ||
| file_path: 09-developers-guide | ||
| - page: Architecture | ||
| file_path: 09-developers-guide/architecture | ||
| - page: Key modules | ||
| file_path: 09-developers-guide/key-modules |
Comment on lines
6
to
10
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Redistribution and use in source and/or binary forms, with or without |
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * http://www.apache.org/licenses/LICENSE-2.0 |
| Please read and follow all guidelines in the project's agent documentation: | ||
|
|
||
| - Start with the table of contents: `.agents/_TOC.md`. | ||
| - Start with the table of contents: `./agents/_TOC.md`. |
|
|
||
|
|
||
| # Dependencies of `io.spine.tools:validation-docs:2.0.0-SNAPSHOT.416` | ||
| # Dependencies of `io.spine.tools:validation-docs:2.0.0-SNAPSHOT.415` |
Comment on lines
+16
to
+19
| | `:context` | Language-agnostic validation model and built-in option handling (views/reactions) shared by language plugins. | | ||
| | `:java` | Spine Compiler plugin for Java: generates/injects validation code; loads custom options via `ValidationOption` SPI and custom validators discovered by `:ksp`. | | ||
| | `:ksp` | KSP processor that discovers classes annotated with `@io.spine.validation.Validator` and writes a message→validator mapping resource consumed by `:java`. | | ||
| | `:jvm-runtime` | Runtime library used by generated code: `ValidationException`, validation/constraint APIs, `MessageValidator`, and error Protobuf types. | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the merge of #293 (`Developer's guide`), which was merged accidentally because of a misconfiguration of branch protection rules.
This PR contains a single revert commit produced via `git revert -m 1` of the merge commit `3375d667`, restoring `master` to its state immediately before the merge.
The original changes are preserved on the `reapply-pr-293` branch and will be re-introduced through a separate PR for proper review.
Test plan