Skip to content

Re-apply PR #293 (Developer's guide)#296

Merged
alexander-yevsyukov merged 13 commits intomasterfrom
reapply-pr-293
May 8, 2026
Merged

Re-apply PR #293 (Developer's guide)#296
alexander-yevsyukov merged 13 commits intomasterfrom
reapply-pr-293

Conversation

@alexander-yevsyukov
Copy link
Copy Markdown
Collaborator

Re-applies the changes from #293 (`Developer's guide`), which was accidentally merged because of a misconfiguration of branch protection rules and is being reverted in #295.

The tree state of this branch is identical to the state of `master` before the revert, i.e. it preserves the exact contents that were on `master` after the original PR #293 merge.

Base branch

The base of this PR is set to `revert-pr-293` so that the diff cleanly shows the re-applied changes. Once #295 is merged, switch the base of this PR to `master`.

Original PR description

This PR adds the "Validation developer guide" to the documentation. The navigation of the preview site was changed so that "User guide" and "Developer guide" appear as top-level nodes on the left side panel. This, in turn, required having `user` and `developer` subdirectories under `docs/validation/`.

This PR also includes latest updates from `site-commons` that bring improved table styes and page level navigation on the right.

Other notable changes

  • The `/writer` skill was updated to use typographic quotes when referencing sections and pages in the text body.
  • `embed-code.yml` was updated with the `root` code path, `code-includes` parameter was also added to avoid copying files under `.git/` which failed the build. It will also make the embedding work a bit faster because we won't copy anything but embedded content candidates.

Test plan

Re-applies the changes from PR #293 (#293) which were accidentally merged due to a misconfiguration of branch protection rules. Pairs with the revert PR so the same changes can go through proper review.
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

![Typical custom option](typical_custom_option.jpg)

P2 Badge Restore custom option diagram asset

This page embeds typical_custom_option.jpg, but the commit deletes the image from the old location and does not add it under the new user/05-custom-validation/ directory, so the rendered page shows a broken image instead of the workflow diagram.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

- [Using `ValidatorRegistry`](validator-registry.md)
- [Custom validation](../05-custom-validation/)
- [Architecture](../09-developers-guide/architecture.md)
- [Developer's guide](../06-developers-guide/)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update stale developer guide links

The docs restructure moved the guide under docs/content/docs/validation/developer/**, but this page still links to ../06-developers-guide/, which now resolves to a non-existent path (user/06-developers-guide) and produces a dead “Developer's guide” link for readers; the same broken target is repeated in user/04-validators/implement-a-validator.md and user/05-custom-validation/pass-to-compiler.md.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexander-yevsyukov this may be the case.

@alexander-yevsyukov alexander-yevsyukov self-assigned this May 7, 2026
@alexander-yevsyukov alexander-yevsyukov requested a review from armiol May 7, 2026 20:47
Base automatically changed from revert-pr-293 to master May 8, 2026 08:31
Copilot AI review requested due to automatic review settings May 8, 2026 08:40
Copy link
Copy Markdown
Collaborator

@armiol armiol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread docs/content/docs/validation/developer/extension-points.md Outdated
- [Using `ValidatorRegistry`](validator-registry.md)
- [Custom validation](../05-custom-validation/)
- [Architecture](../09-developers-guide/architecture.md)
- [Developer's guide](../06-developers-guide/)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexander-yevsyukov this may be the case.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR re-applies the documentation-focused changes from #293, restructuring the Validation docs into separate User and Developer guides, updating the docs toolchain configuration, and bumping related build/tooling versions.

Changes:

  • Restructured Hugo docs navigation into top-level “Validation user guide” and “Validation developer guide”, adding many new/updated guide pages and removing the old 09-developers-guide section.
  • Updated docs tooling/config (Go module metadata for docs, embed-code.yml paths/includes, site-commons module versions).
  • Bumped project/snapshot versions and updated the Gradle wrapper distribution.

Reviewed changes

Copilot reviewed 43 out of 72 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
version.gradle.kts Bumps Validation version and updates description comment.
tests/validator/build.gradle.kts Updates comment wording for KSP output usage.
README.md Simplifies README structure; adds reference-style links and redirects “custom validation” to docs.
pom.xml Bumps project version and related dependency versions.
java-bundle/build.gradle.kts Updates copyright year and Apache license URL.
gradlew.bat Updates Windows wrapper script behavior (contains an exit-flow bug; see comments).
gradlew Updates link to Gradle template source revision.
gradle/wrapper/gradle-wrapper.properties Updates Gradle distribution URL and adds retry-related properties.
gradle-plugin/src/main/kotlin/io/spine/tools/validation/gradle/ValidationSdk.kt Renames internal constant and updates artifact name interpolation.
docs/go.sum Adds Go sums for docs module dependencies.
docs/go.mod Adds indirect dependency on site-commons.
docs/data/docs/validation/2-0-0-snapshot/sidenav.yml Splits sidenav into user/developer top-level sections with updated paths.
docs/content/docs/validation/user/05-custom-validation/summary.md Updates links to point at the new developer docs locations.
docs/content/docs/validation/user/05-custom-validation/register-the-option.md Adds new documentation page.
docs/content/docs/validation/user/05-custom-validation/pass-to-compiler.md Updates content; “What’s next” link target currently wrong.
docs/content/docs/validation/user/05-custom-validation/implement-the-view.md Adds new documentation page.
docs/content/docs/validation/user/05-custom-validation/implement-the-reaction.md Adds new documentation page.
docs/content/docs/validation/user/05-custom-validation/implement-the-generator.md Adds new documentation page.
docs/content/docs/validation/user/05-custom-validation/declare-the-option.md Adds new documentation page.
docs/content/docs/validation/user/05-custom-validation/declare-event-and-view.md Adds new documentation page.
docs/content/docs/validation/user/05-custom-validation/_index.md Adds new section index (contains a duplicated nav entry; see comments).
docs/content/docs/validation/user/04-validators/validator-registry.md Adds new documentation page.
docs/content/docs/validation/user/04-validators/implement-a-validator.md Adds/updates content; “What’s next” link target currently wrong.
docs/content/docs/validation/user/04-validators/_index.md Updates formatting and developer guide link.
docs/content/docs/validation/user/03-built-in-options/repeated-and-map-fields.md Adds new documentation page.
docs/content/docs/validation/user/03-built-in-options/oneof-fields.md Minor capitalization fix in link text.
docs/content/docs/validation/user/03-built-in-options/message-level-options.md Adds new documentation page.
docs/content/docs/validation/user/03-built-in-options/field-level-options.md Adds new documentation page.
docs/content/docs/validation/user/03-built-in-options/_index.md Refactors “source of truth” section (includes a whitespace-only line; see comments).
docs/content/docs/validation/user/02-concepts/options-overview.md Adds new documentation page.
docs/content/docs/validation/user/02-concepts/error-messages.md Adds new documentation page.
docs/content/docs/validation/user/02-concepts/_index.md Adds new documentation page.
docs/content/docs/validation/user/01-getting-started/generated-code.md Adds new documentation page.
docs/content/docs/validation/user/01-getting-started/first-model.md Adds new documentation page.
docs/content/docs/validation/user/01-getting-started/build-project.md Adds new documentation page (frontmatter title inconsistency; see comments).
docs/content/docs/validation/user/01-getting-started/adding-to-build.md Updates plugin version in docs snippet.
docs/content/docs/validation/user/01-getting-started/_index.md Adds new documentation page.
docs/content/docs/validation/user/00-intro/target-audience.md Adds new documentation page.
docs/content/docs/validation/user/00-intro/philosophy.md Adds new documentation page.
docs/content/docs/validation/user/00-intro/_index.md Updates terminology and expands introductory content.
docs/content/docs/validation/developer/validation-model.md Adds developer guide page.
docs/content/docs/validation/developer/testing-strategy.md Adds developer guide page.
docs/content/docs/validation/developer/runtime-library.md Adds developer guide page.
docs/content/docs/validation/developer/overview-and-audience.md Adds developer guide page.
docs/content/docs/validation/developer/key-modules.md Adds developer guide page.
docs/content/docs/validation/developer/java-code-generation.md Adds developer guide page.
docs/content/docs/validation/developer/extension-points.md Adds developer guide page.
docs/content/docs/validation/developer/build-and-release.md Adds developer guide page.
docs/content/docs/validation/developer/architecture.md Adds developer guide page.
docs/content/docs/validation/developer/adding-a-built-in-option.md Adds developer guide page.
docs/content/docs/validation/09-developers-guide/key-modules.md Removes legacy developer guide page.
docs/content/docs/validation/09-developers-guide/architecture.md Removes legacy developer guide page.
docs/content/docs/validation/09-developers-guide/_index.md Removes legacy developer guide index.
docs/content/docs/validation/_index.md Updates landing page links to new user/developer guide structure.
docs/_settings/embed-code.yml Adds root/java/context code paths and include filters for embedding.
docs/_preview/go.sum Updates preview module sums for updated Hugo/site-commons deps.
docs/_preview/go.mod Updates preview module requires for updated Hugo/site-commons deps.
docs/_preview/content/_index.md Fixes preview link to point at the new docs root.
dependencies.md Regenerates dependency report for new snapshot version.
context/src/main/kotlin/io/spine/tools/validation/ValidationPlugin.kt Adds trailing comment to closing paren.
context/src/main/kotlin/io/spine/tools/validation/ErrorPlaceholder.kt Fixes grammar in KDoc about runtime duplication.
CLAUDE.md Fixes path to .agents/_TOC.md.
buildSrc/src/main/kotlin/io/spine/dependency/local/Validation.kt Bumps local Validation dependency version.
buildSrc/src/main/kotlin/fat-jar.gradle.kts Updates copyright year/URL and removes an exclusion block.
.gitignore Ignores /.claude/worktrees/.
.agents/skills/writer/SKILL.md Adds guideline about typographic quotes usage for doc references.
Comments suppressed due to low confidence (3)

docs/content/docs/validation/user/05-custom-validation/pass-to-compiler.md:76

  • This link points to ../06-developers-guide/, but the developer docs were moved under validation/developer/ (see docs/content/docs/validation/developer/* and sidenav.yml entries). Update the link target to the new Developer’s Guide location (e.g. ../../developer/ or a concrete page like ../../developer/overview-and-audience.md).
    docs/content/docs/validation/user/04-validators/implement-a-validator.md:140
  • This link points to ../06-developers-guide/, but the developer docs are now under validation/developer/ (see docs/content/docs/validation/developer/* and sidenav.yml). Update the link target to the new Developer’s Guide location (e.g. ../../developer/ or ../../developer/overview-and-audience.md).
    docs/content/docs/validation/user/03-built-in-options/_index.md:48
  • There is a whitespace-only line here. Please remove it to avoid trailing-whitespace noise in diffs and potential markdown lint issues.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread gradlew.bat
Comment thread gradlew.bat
Copilot AI review requested due to automatic review settings May 8, 2026 19:09
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 44 out of 73 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (3)

docs/content/docs/validation/user/05-custom-validation/pass-to-compiler.md:76

  • The "What's next" link points to ../06-developers-guide/, but the Developer guide content is now under docs/content/docs/validation/developer/ (e.g. ../../developer/ or ../../developer/overview-and-audience.md from this page). Update this link so it resolves to the new Developer guide location.
    docs/content/docs/validation/user/04-validators/implement-a-validator.md:141
  • The "What's next" section links to ../06-developers-guide/, but the Developer guide was moved under docs/content/docs/validation/developer/. Please update this link to the new path (e.g. ../../developer/ or a specific page under it) so navigation doesn't 404.
    docs/content/docs/validation/user/03-built-in-options/_index.md:48
  • Line contains a large run of trailing whitespace before the reference link definitions. This tends to create noisy diffs and can trip markdown linters; please remove the stray whitespace-only line.

Comment thread gradlew.bat
Comment on lines 48 to 55
echo. 1>&2
echo ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. 1>&2
echo. 1>&2
echo Please set the JAVA_HOME variable in your environment to match the 1>&2
echo location of your Java installation. 1>&2

goto fail
"%COMSPEC%" /c exit 1

Comment thread gradlew.bat
Comment on lines 62 to 69
echo. 1>&2
echo ERROR: JAVA_HOME is set to an invalid directory: %JAVA_HOME% 1>&2
echo. 1>&2
echo Please set the JAVA_HOME variable in your environment to match the 1>&2
echo location of your Java installation. 1>&2

goto fail
"%COMSPEC%" /c exit 1

@alexander-yevsyukov alexander-yevsyukov merged commit f1d3e78 into master May 8, 2026
12 checks passed
@alexander-yevsyukov alexander-yevsyukov deleted the reapply-pr-293 branch May 8, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants