Slice 18: Multi-Currency — Apply Conversion to Burn Rate - #42
Merged
Conversation
Every subscription's native-currency cost now converts to the user's preferred_currency via cached fx_rates before summing into burn-rate totals; a currency pair with no cached rate is excluded and flagged via UnresolvedSubscriptionIds instead of failing the whole request. Stored cost_amount/currency remain untouched (read-time projection). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
preferred_currencyvia cachedfx_ratesbefore summing into weekly/monthly/yearly totals.BurnRateResultnow reportshomeCurrencyandunresolvedSubscriptionIds(currency pairs with no cached rate — excluded from totals rather than failing the request).IFxRateService.GetRateAsync(cache-only read, no live API call) andIUserRepository.GetPreferredCurrencyAsync(new, minimal — needed to resolve the caller's home currency inDashboardController).cost_amount/currencyonuser_subscriptionsare never mutated.Test plan
dotnet test tests/SubVora.Application.Tests— 10/10 pass, including newConvertsMixedCurrencySubscriptionsToHomeCurrencyBeforeSummingandMissingFxRateForAPair_ExcludesThatSubscriptionAndFlagsItdotnet test tests/SubVora.Api.Tests— 49/49 pass (DashboardController tests unaffected, single-currency behavior preserved)dotnet test tests/SubVora.Infrastructure.Tests— 19/19 passCloses #19