Actually find and warn on private @Listener methods.#1233
Merged
stephan-gh merged 1 commit intoSpongePowered:bleedingfrom Apr 13, 2017
Merged
Actually find and warn on private @Listener methods.#1233stephan-gh merged 1 commit intoSpongePowered:bleedingfrom
stephan-gh merged 1 commit intoSpongePowered:bleedingfrom
Conversation
Deamon5550
reviewed
Mar 4, 2017
| } | ||
|
|
||
| for (Method method : invalidMethods) { | ||
| SpongeImpl.getLogger().warn("The method {} on {} has @{} but has the wrong signature", method, |
Contributor
There was a problem hiding this comment.
Seeing as you're changing this, it would probably be good to give a more helpful error message (eg. if its private warn specifically that event listeners cannot be private).
JBYoshi
force-pushed
the
warn-private-listeners
branch
2 times, most recently
from
a1973b4 to
c1088d7
Compare
Member
|
Nice idea. As an addition/alternative I would suggest using an annotation processor, that checks those things at compile time. |
Member
Author
JBYoshi
force-pushed
the
warn-private-listeners
branch
2 times, most recently
from
2e09bb8 to
f179b46
Compare
stephan-gh
force-pushed
the
warn-private-listeners
branch
from
f179b46 to
8111124
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://forums.spongepowered.org/t/plugin-logger-does-not-do-anything/17805?u=jbyoshi