Add error message for @Listener methods.#1513
Merged
stephan-gh merged 1 commit intoSpongePowered:bleedingfrom Apr 13, 2017
Merged
Add error message for @Listener methods.#1513stephan-gh merged 1 commit intoSpongePowered:bleedingfrom
stephan-gh merged 1 commit intoSpongePowered:bleedingfrom
Conversation
JBYoshi
force-pushed
the
warn-private-listeners
branch
from
179a712 to
e48b63d
Compare
stephan-gh
suggested changes
Mar 6, 2017
| msg.printMessage(Diagnostic.Kind.ERROR, "method must return void", method); | ||
| } | ||
| List<? extends VariableElement> parameters = method.getParameters(); | ||
| if (parameters.isEmpty() || isTypeSubclass(parameters.get(0), EVENT_CLASS)) { |
Contributor
There was a problem hiding this comment.
This should be || !isTypeSubClass(...) because you want to show the error if the method doesn't have an Event as first parameter
| Types types = processingEnv.getTypeUtils(); | ||
|
|
||
| TypeMirror event = types.getDeclaredType(elements.getTypeElement(subclass)); | ||
| return types.isAssignable(event, typedElement.asType()); |
Contributor
There was a problem hiding this comment.
The order of the arguments for isAssignable is wrong here. From the Javadocs:
returns true if and only if the first type is assignable to the second
You want to check if the parameter type extends Event which means that you need to check if the parameter is assignable to Event. Event isn't directly assignable to a subclass of it.
stephan-gh
reviewed
Mar 6, 2017
| @@ -1 +1,2 @@ | |||
| org.spongepowered.plugin.processor.PluginProcessor | |||
| org.spongepowered.processor.plugin.PluginProcessor | |||
Contributor
There was a problem hiding this comment.
While I understand why you move it, I would prefer if it stays in its original package so we don't break older versions of SpongeGradle
Member
Author
There was a problem hiding this comment.
@Minecrell Moved back to the original package.
liach
reviewed
Mar 6, 2017
|
|
||
| return false; | ||
| } | ||
| } |
| Types types = processingEnv.getTypeUtils(); | ||
|
|
||
| TypeMirror event = types.getDeclaredType(elements.getTypeElement(subclass)); | ||
| return types.isAssignable(event, typedElement.asType()); |
JBYoshi
force-pushed
the
warn-private-listeners
branch
from
e48b63d to
d20b3f3
Compare
stephan-gh
approved these changes
Mar 7, 2017
liach
approved these changes
Mar 7, 2017
ST-DDT
approved these changes
Mar 7, 2017
kashike
approved these changes
Mar 7, 2017
JBYoshi
force-pushed
the
warn-private-listeners
branch
3 times, most recently
from
a116968 to
203d186
Compare
me4502
approved these changes
Mar 20, 2017
JBYoshi
force-pushed
the
warn-private-listeners
branch
2 times, most recently
from
b4c057a to
376c1e3
Compare
stephan-gh
force-pushed
the
warn-private-listeners
branch
from
376c1e3 to
e2a1f7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See SpongePowered/Sponge#1233 (comment).