Skip to content

Conversation

@laysakura
Copy link
Contributor

@laysakura laysakura commented Jun 10, 2022

Issue number and link

Fixes: #160

Describe your changes

  • Add BLOB type in syntax
  • Add SqlValue::Blob and its mutual translation to/from Vec<u8>

Note that we do not have any way to perform e2e testing because no source readers / sink writers support binary payload.

Checklist before requesting a review

  • I follow the Semantic Pull Requests rules (bugfix/feature)
  • I specified links to related issues (must: bugfix, want: feature)
  • I have performed a self-review of my code (bugfix/feature)
  • I have added thorough tests (bugfix/feature)
  • I have edited ## [Unreleased] section in CHANGELOG.md following keep a changelog syntax (bugfix/feature)
  • I {made/will make} a related pull request for documentation repo (feature)

@laysakura laysakura changed the title wip: adding blob type feat: add blob type Jun 13, 2022
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #187 (fd63318) into main (32ee55e) will decrease coverage by 0.07%.
The diff coverage is 43.18%.

@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
- Coverage   87.43%   87.36%   -0.08%     
==========================================
  Files         203      204       +1     
  Lines       12032    12076      +44     
==========================================
+ Hits        10520    10550      +30     
- Misses       1512     1526      +14     
Impacted Files Coverage Δ
springql-core/src/pipeline/relation/sql_type.rs 81.25% <0.00%> (-8.41%) ⬇️
...e/autonomous_executor/row/value/sql_convertible.rs 0.00% <0.00%> (ø)
...e/src/sql_processor/sql_parser/pest_parser_impl.rs 87.14% <42.85%> (-0.59%) ⬇️
...onomous_executor/row/value/sql_convertible/blob.rs 50.00% <50.00%> (ø)
...omous_executor/row/value/sql_value/nn_sql_value.rs 65.53% <55.55%> (-0.96%) ⬇️
..._engine/autonomous_executor/row/value/sql_value.rs 75.51% <0.00%> (+0.68%) ⬆️
...ql_processor/sql_parser/pest_parser_impl/helper.rs 92.85% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32ee55e...fd63318. Read the comment docs.

@laysakura laysakura marked this pull request as ready for review June 13, 2022 05:52
@laysakura laysakura merged commit 4906084 into main Jun 13, 2022
@laysakura laysakura deleted the feat/blob branch June 13, 2022 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Binary type

2 participants