Remove unused code #574
Closed
Remove unused code #574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nipap-cli/nipap_cli/command.py
Outdated
Member
There was a problem hiding this comment.
These should probably not be removed, rather just moved. Look at the comment at https://github.com/SpriteLink/NIPAP/blob/master/pynipap/pynipap.py#L317
This is rendered in the docs (by Sphinx): http://nipap.readthedocs.org/en/v0.25.0/pynipap/#pynipap.VRF.rt
Right now, there is no docs generated for command.py, but if we ever do, it would be nice if we got some comments to these variables.
garberg
added a commit
to garberg/NIPAP
that referenced
this pull request
May 5, 2015
Made some modifications to SpriteLink#574. A comment was misplaced, kept pylons imports intact and made sure a renderer is imported into the pylons base module.
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused code according to scrutinizer-ci