Don't use any default www-user #587
Conversation
nipap/nipap.conf.dist
Outdated
There was a problem hiding this comment.
Is there a point in keeping the "@Local" part of the username? Shouldn't that be removed as well?
There was a problem hiding this comment.
Is it possible / is there an use-case, to use it without local auth (i.e. with ldap auth)? If yes, then it should be removed. If however nipap-www is intended to always connect using local auth, it should be kept in my opinion.
There was a problem hiding this comment.
Right, but the sed line we have right now in postinst already adds "@Local", so it won't really make a difference to the end result. What it does though is look confusing, IMHO :P
We are only talking about the default value here, anyone is free to add @Local or something else to their configuration.
There was a problem hiding this comment.
I've removed it. Do you want to remove everything up to the ip, since sed adds that? I.e.
xmlrpc_uri = 127.0.0.1:1337
dosomder
force-pushed
the
572-default-www-user
branch
from
d801164 to
e333a66
Compare
Otherwise, nipap-www will always automatically create the user test with password test
dosomder
force-pushed
the
572-default-www-user
branch
from
e333a66 to
c48a4bb
Compare
Don't use any default www-user
2 participants
Otherwise, nipap-www will always automatically create the user test with password test.
Fix for #572