Skip to content

Conversation

@job
Copy link
Contributor

@job job commented Oct 2, 2014

Ensure users don't leave easily readable .nipaprc file around

@plajjan
Copy link
Member

plajjan commented Oct 6, 2014

Nice!
This should really go in "nipap" and not the module itself, I see that you only put this code where the current code for reading the configuration file is, but that should be moved... I'll look into that. Rebase impending ;)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should mimic SSH;

Permissions 0777 for '.ssh/id_rsa' are too open.
It is recommended that your private key files are NOT accessible by others.
This private key will be ignored.

Ie, drop the "Command failed" (anyone should get that much) and print "Permissions XXX for ~/.nipaprc are too open". I think this should be printed to stderr too. You should probably use string formatting for the path to the configuration file.

@job job force-pushed the fix-perms-nipaprc branch from c94642d to e5b3da5 Compare October 7, 2014 13:23
@plajjan
Copy link
Member

plajjan commented Oct 7, 2014

Merged through CLI. Closing.

@plajjan plajjan closed this Oct 7, 2014
@plajjan plajjan added this to the Version 0.27 - Icarus milestone Oct 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants