refactor: Extract hardcoded constants into node and network config

[SIDDHANTCOOKIE]

Addressed Issues:

This PR refactors the Minichain codebase to decouple configuration parameters and hardcoded constants from the core logic files. It introduces two dedicated configuration files to manage constants moving forward.

Changes Made

• Node Configurations (node_config.py): Extracted parameters that individual node operators are free to adjust based on their system requirements:
  • P2P fault/banning thresholds (MALFORMED_THRESHOLD, FAILED_THRESHOLD, etc.)
  • Mempool size limits (MEMPOOL_MAX_SIZE, MEMPOOL_TX_PER_BLOCK)
  • Proof-of-Work boundaries (MINING_MAX_NONCE)
• Network Configurations (network_config.py): Extracted network-wide parameters that require strict conformity across all nodes to preserve consensus:
  • Protocol rules (PROTOCOL_ID, SUPPORTED_MESSAGE_TYPES, MAX_FRAME_BYTES)
  • Mining constants (DEFAULT_MINING_REWARD)
  • Chain validation rules (MAX_FUTURE_BLOCK_TIME_MS)
• Core Refactoring: Updated chain.py, mempool.py, p2p.py, pow.py, and state.py to securely import these parameters rather than relying on internal hardcoded values.

Screenshots/Recordings:

TODO: If applicable, add screenshots or recordings that demonstrate the interface before and after the changes.

Additional Notes:

AI Usage Disclosure:

We encourage contributors to use AI tools responsibly when creating Pull Requests. While AI can be a valuable aid, it is essential to ensure that your contributions meet the task requirements, build successfully, include relevant tests, and pass all linters. Submissions that do not meet these standards may be closed without warning to maintain the quality and integrity of the project. Please take the time to understand the changes you are proposing and their impact. AI slop is strongly discouraged and may lead to banning and blocking. Do not spam our repos with AI slop.

Check one of the checkboxes below:

• This PR does not contain AI-generated code at all.
• This PR contains AI-generated code. I have read the AI Usage Policy and this PR complies with this policy. I have tested the code locally and I am responsible for it.

I have used the following AI models and tools: TODO

Checklist

• My PR addresses a single issue, fixes a single bug or makes a single improvement.
• My code follows the project's code style and conventions
• If applicable, I have made corresponding changes or additions to the documentation
• If applicable, I have made corresponding changes or additions to tests
• My changes generate no new warnings or errors
• I have joined the Discord server and I will share a link to this PR with the project maintainers there
• I have read the Contribution Guidelines
• Once I submit my PR, CodeRabbit AI will automatically review it and I will address CodeRabbit's comments.
• I have filled this PR template completely and carefully, and I understand that my PR may be closed without review otherwise.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (2)

• main
• develop

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 861436e8-9238-432d-bd96-b666c9b0c764

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/extract-config-files

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}