Try to parse TL as UserFn before DB in legacy binary (de)serializer#1
Closed
StachuDotNet wants to merge 1 commit into
Closed
Try to parse TL as UserFn before DB in legacy binary (de)serializer#1StachuDotNet wants to merge 1 commit into
StachuDotNet wants to merge 1 commit into
Conversation
Owner
Author
|
PR in wrong repo. |
StachuDotNet
pushed a commit
that referenced
this pull request
Mar 1, 2023
StachuDotNet
added a commit
that referenced
this pull request
Jan 30, 2024
…ension Attempt #1: Publish VS Code Extension
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the problem/goal being addressed?
If you
currently the user function is (seemingly consistently) 'parsed' as a DB TopLevel rather than a UserFn.
What is the solution to this problem?
In the legacy binary serialization server, attempt to parse UserFns before DBs.
How are you sure this works/how was this tested?
I've tested this in the UI, and confirmed no regressions in other tests.
As existing integration tests already covered this bug (when the integration tests target F#, which they shortly will by default), I did not write new tests to cover this.