fix: preserve editor focus when opening dropdowns - #507
Merged
Conversation
🦋 Changeset detectedLatest commit: f1f342e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for stacks-editor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
alexwarren
marked this pull request as ready for review
August 5, 2026 14:16
alexwarren
changed the title
dancormier
approved these changes
Aug 5, 2026
dancormier
left a comment
dancormier
left a comment
Contributor
There was a problem hiding this comment.
Really solid change @alexwarren. I looked through the code plus tested manually and it all seems good. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mousedownwithin the built-in editor menu container so mouse activation does not blur the editorContext
This fixes the underlying Stacks Editor focus-handling gap exposed by Stacks 2.9.0. When a mouse opened an editor dropdown, the editor click handler restored focus to the editor; Stacks then treated that focus move as leaving the trigger/popover pair and immediately dismissed the menu.
Stacks Editor already documents this focus-preservation behavior in two places:
setupPluginContainer()says toolbar mouse interactions are cancelled to prevent the editor from blurring, andMenuViewsays the standardStacksEditorsetup handles this automatically. However, the built-in setup never installed the documentedmousedownhandler. This change closes that existing implementation gap; Stacks 2.9's focus-leave behavior merely made the gap observable.This is the upstream fix for the temporary Stack Overflow workarounds in StackEng/StackOverflow#26004 and StackEng/StackOverflow#26010.
Testing
npm run lintnpm run test:unit -- --runInBand— 48 suites, 1,092 tests passednpm run test:e2e— 195 tests passed across Chromium, Firefox, and WebKitnpm run buildgit diff --check