Merged
Conversation
Contributor
|
I wonder if we can save having to touch every provider by having the diff code downcase both sides before starting. |
Collaborator
Author
|
@captncraig I considered that. There are pros and cons both ways. This is all going to change when we implement the NO_PURGE and record-level "no touch" stuff. So, I think this is sufficient. (assuming all the tests pass) |
Contributor
|
All tests pass for: BIND We can merge this if you are ok with putting the Downcase call in a more central place. |
fix spelling mistake
* spelling mistake fix spelling mistake * missing double quote missing double quote =D
koesie10
pushed a commit
to koesie10/dnscontrol
that referenced
this pull request
Nov 14, 2017
* Downcase DNS names * Document opinions
pmoroney
pushed a commit
to pmoroney/dnscontrol
that referenced
this pull request
Jan 11, 2018
* Downcase DNS names * Document opinions
rblenkinsopp
pushed a commit
to rblenkinsopp/dnscontrol
that referenced
this pull request
Aug 21, 2020
* Downcase DNS names * Document opinions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This still needs a lot of testing.