docs: use the StackGuardian icon as the site logo - #277
Closed
refeed wants to merge 1 commit into
Closed
Conversation
Replaces img/tirith.png in the navbar with the StackGuardian mark, which is what appears top-left on the landing page and on every docs page. The alt text changes with it: it said "Tirith Logo", and the image is now the StackGuardian logo, so a screen reader would otherwise announce the wrong name. The favicon still points at img/tirith.png. Left deliberately -- swapping the browser-tab icon changes how the site is identified in a tab strip and in bookmarks, which is a separate call from the in-page logo.
|
❌ The last analysis has failed. |
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This was referenced Aug 13, 2026
Member
Author
|
Superseded by #279, which carries this commit unchanged alongside the button-colour change so the two land as one review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swaps the navbar logo for the StackGuardian mark. That logo is what sits top-left on the landing page and on every documentation page, so it is the one visible on https://stackguardian.github.io/tirith/.
logo: { - alt: 'Tirith Logo', - src: 'img/tirith.png', + alt: 'StackGuardian logo', + src: 'img/sg-icon.png', },The asset is added at
documentation/static/img/sg-icon.png— 512×512 PNG, RGBA, 17.7 KB.The
alttext changes with it. It read "Tirith Logo", and the image is now the StackGuardian mark, so leaving it would have a screen reader announce the wrong name for the image.Verified
npm run buildpasses, and the built output references the new asset rather than resolving to a 404:Both the light and dark variants pick it up — Docusaurus emits two
<img>elements for a themed logo, and a change that only landed on one would look correct until someone toggled the theme.build/img/sg-icon.pngis emitted.Not changed: the favicon
favicon: 'img/tirith.png'is untouched, andimg/tirith.pngis now used for nothing else. That is deliberate rather than an oversight: the favicon is how the site is identified in a tab strip, in history and in bookmarks, which is a separate decision from the in-page logo. Say the word and it is a one-line follow-up — or the old asset can be deleted at the same time.