fix(ci): filter Kokoro release check to releases with general assets#26
Merged
fix(ci): filter Kokoro release check to releases with general assets#26
Conversation
The original tag-name-only filter shipped in #24 would have flagged `model-files-v1.1` as an upgrade candidate even though that release ships only a Mandarin variant (`kokoro-v1.1-zh.onnx` / `voices-v1.1-zh.bin`). Bumping engine.py URLs to it would silently swap the multilingual model for a Chinese-focused one. Tightens the jq filter to require both `kokoro-vX.Y.onnx` and `voices-vX.Y.bin` assets to be present in the release before treating it as a successor. With this in place the workflow currently resolves `model-files-v1.0` (== pinned) and reports up-to-date, as it should. A future general release (with non-suffixed asset names) will surface correctly. This was meant to land as a follow-up commit on #24 but the squash merge captured only the first commit on that branch. Filing as its own PR. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #24 that didn't make it through the squash merge. Tightens the upstream-release filter so the workflow doesn't treat Mandarin-variant-only releases as successors.
The bug
The filter as merged accepts any release whose tag starts with `model-files-v`:
```yaml
--jq '[.[] | select(.tag_name | startswith("model-files-v"))][0].tag_name'
```
That matches `model-files-v1.1`, but v1.1 ships only `kokoro-v1.1-zh.onnx` and `voices-v1.1-zh.bin` — a Mandarin-focused sibling, not a successor to v1.0. On the next scheduled run the workflow would open an upgrade issue, and bumping the URLs as suggested would silently swap the multilingual model for a Chinese-focused one.
The fix
Filter requires the release to contain BOTH `kokoro-vX.Y.onnx` AND `voices-vX.Y.bin` assets (no variant suffix) before treating it as the latest:
```yaml
--jq '
[
.[]
| select(.tag_name | startswith("model-files-v"))
| select([.assets[] | .name | test("^kokoro-v[0-9.]+\.onnx$")] | any)
| select([.assets[] | .name | test("^voices-v[0-9.]+\.bin$")] | any)
][0].tag_name
'
```
Verified locally — with this filter, the latest resolved tag is `model-files-v1.0` (the same as what's pinned), so the workflow reports up-to-date instead of opening a spurious issue.
Test plan