Skip to content

fix(ci): filter Kokoro release check to releases with general assets #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuBehan merged 1 commit into from
Apr 30, 2026
Merged

fix(ci): filter Kokoro release check to releases with general assets #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions .github/workflows/check-kokoro-model.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,17 +46,33 @@ jobs:
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
# Filter to model-files-v* tags so the kokoro_onnx Python package
# releases (which use plain v* tags) don't confuse us.
tag=$(gh api repos/thewh1teagle/kokoro-onnx/releases \
--jq '[.[] | select(.tag_name | startswith("model-files-v"))][0].tag_name')
# Two filters here, both essential:
#
# 1. tag_name starts with `model-files-v` — kokoro-onnx also
# publishes plain `v*` tags for the Python package; we don't
# care about those.
#
# 2. release contains BOTH `kokoro-vX.Y.onnx` AND `voices-vX.Y.bin`
# assets (no variant suffix). This skips Mandarin-only sibling
# releases like `model-files-v1.1` whose assets are
# `kokoro-v1.1-zh.onnx` / `voices-v1.1-zh.bin` — a tag-only
# check would treat that as a successor and prompt a broken
# URL bump.
tag=$(gh api repos/thewh1teagle/kokoro-onnx/releases --jq '
[
.[]
| select(.tag_name | startswith("model-files-v"))
| select([.assets[] | .name | test("^kokoro-v[0-9.]+\\.onnx$")] | any)
| select([.assets[] | .name | test("^voices-v[0-9.]+\\.bin$")] | any)
][0].tag_name
')
if [ -z "$tag" ] || [ "$tag" = "null" ]; then
echo "::warning::could not resolve latest upstream model-files-v* tag; skipping"
echo "::warning::could not resolve latest upstream model-files-v* tag with general (non-variant) assets; skipping"
echo "tag=" >> "$GITHUB_OUTPUT"
exit 0
fi
echo "tag=$tag" >> "$GITHUB_OUTPUT"
echo "latest upstream tag: $tag"
echo "latest upstream tag (with general assets): $tag"

- name: ensure model-upgrade label exists
if: steps.latest.outputs.tag != '' && steps.latest.outputs.tag != steps.pinned.outputs.tag
Expand Down