Closed
Conversation
result. In StackStorm v2.3.0, breaking client change has been introduced for query method as part of StackStorm/st2#3514.
Contributor
|
Hmmm. Problem with this one is that existing users need to manually run |
|
@LindsayHill I think the breaking change is now replaced with backward compatible API StackStorm/st2#3616. I think we can close this PR? cc: @humblearner @Kami |
Contributor
Author
|
Yep, closing 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes actions which use st2client
query()method so they work again after a breaking change in StackStorm/st2#3514 which has been included in v2.3.1.In the future we need to be more careful when we do a breaking client changes like that one. We some how missed that breaking change and I believe we also didn't document it so we need to go back and explicitly document this in upgrade notes of st2 v2.3.
Resolves StackStorm/st2#3606