This repository was archived by the owner on Jul 28, 2020. It is now read-only.
Made the auth backend customizable with attributes#74
Merged
arm4b merged 3 commits intoStackStorm:masterfrom Nov 26, 2019
fuze:master
Merged
Made the auth backend customizable with attributes#74arm4b merged 3 commits intoStackStorm:masterfrom fuze:master
arm4b merged 3 commits intoStackStorm:masterfrom
fuze:master
Conversation
arm4b
suggested changes
Nov 24, 2019
Member
There was a problem hiding this comment.
Thanks for the PR, looks good 👍
One small missing thing: can you please add a Changelog record for this enhancement?
arm4b
approved these changes
Nov 26, 2019
Member
arm4b
left a comment
arm4b
left a comment
There was a problem hiding this comment.
Merging, thanks for contribution!
Member
|
@djolly-fuze One missing thing I noticed a bit late, can you also update other files to reflect this change and make unit tests pass? See |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed some auth config settings to attributes to allow for for customized auth options.