This repository was archived by the owner on Jul 28, 2020. It is now read-only.
Fixed spec tests and default recipe to handle new st2auth config#75
Merged
arm4b merged 6 commits intoStackStorm:masterfrom Dec 11, 2019
fuze:master
Merged
Fixed spec tests and default recipe to handle new st2auth config#75arm4b merged 6 commits intoStackStorm:masterfrom fuze:master
arm4b merged 6 commits intoStackStorm:masterfrom
fuze:master
Conversation
arm4b
suggested changes
Dec 10, 2019
Member
arm4b
left a comment
arm4b
left a comment
There was a problem hiding this comment.
Thanks for the follow-up to #74!
There are still some minor test inconsistencies to fix, according to CI job https://travis-ci.org/StackStorm/chef-stackstorm/jobs/623249551
Co-Authored-By: Eugen C. <armab@users.noreply.github.com>
Contributor
Author
|
Ok, I think it's good now. |
Member
|
That's good, thanks for the fix @djolly-fuze! 👍 |
arm4b
approved these changes
Dec 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the spec and recipes as requested in #74