Fix typo in travis.yml #4274
Merged
Fix typo in travis.yml #4274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LindsayHill
approved these changes
Jul 25, 2018
blag
approved these changes
Jul 25, 2018
fail in container based environments where default terminal size is smaller. Also update affected tests so they don't fail if COLUMNS env variable is set.
pylint tasks by running pylint with concurrency / parallelism of 2 (2 processes).
blag
reviewed
Jul 25, 2018
Makefile
Outdated
| REQUIREMENTS := test-requirements.txt requirements.txt | ||
| PIP_OPTIONS := $(ST2_PIP_OPTIONS) | ||
|
|
||
| PYLINT_CONCURRENCY := $(PYLINT_CONCURRENCY) |
Contributor
There was a problem hiding this comment.
Why this line? I thought environment variables were considered normal variables within makefiles?
Member
Author
There was a problem hiding this comment.
You are correct, I believe it's not needed, but I've done it because we also do that a couple of lines above.
Having said that, I can remove it.
Member
Author
|
Confirmed the change is working on merge to master - https://codecov.io/gh/StackStorm/st2/commit/f92ef089fef5e7c4d770d68baf04ba4c5feaa036 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes typo in the script path in travis config file.