Adds Publish action to RabbitMQ #236
Conversation
There was a problem hiding this comment.
This pack is built around pika. Using kombu probably works as it is a core stackstorm dependency but it is perhaps better to use pika.
Something like https://www.rabbitmq.com/tutorials/tutorial-one-python.html
Pika generally makes for simpler APIs than kombu. In core stackstorm also we are considering a move towards pika.
There was a problem hiding this comment.
Yeah, I chose Kombu since it's required by StackStorm. I'll take a look at switching over to Pika.
|
@manasdk switched to Pika. Let me know how this looks. I can squash the commits to something cleaner before the final merge. |
|
Looks good. Thanks for switching to Pika. Travis is complaiing about line length - Will merge after that gets fixed. |
jtopjian
force-pushed
the
rabbitmq-publish
branch
from
6a644cb to
4aae90c
Compare
This commit adds a publish action to the RabbitMQ pack, allowing a crafted message to be published to a RabbitMQ server.
jtopjian
force-pushed
the
rabbitmq-publish
branch
from
4aae90c to
4b64164
Compare
|
@manasdk looks like everything is checking out. Let me know if there are any other changes to make. |
Adds Publish action to RabbitMQ
|
Done. Merged! |
|
Nice 👍 |
3 participants
This commit adds a publish action to the RabbitMQ pack, allowing a crafted message to be published to a RabbitMQ server.