This repository was archived by the owner on Sep 26, 2018. It is now read-only.
Refactored pack to use a consistent formatter and field sets, support… #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s lists and single instances, also supports 1-level deep field mapping to the dictionary. Also added new actions, list_images, list_sizes
Contributor
|
I bet Kami has strong views on this one. Overall, I see the direction and yeah it does make sense. If we could up with a |
Member
|
Thanks and sorry for the delay. I will look into this today. |
Member
|
Good change. LGTM +1. I will merge this and push some minor style changes afterwards. |
Kami
added a commit
that referenced
this pull request
Nov 17, 2015
Refactored pack to use a consistent formatter and field sets, support…
emedvedev
pushed a commit
that referenced
this pull request
Apr 4, 2016
Refactored pack to use a consistent formatter and field sets, support…
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored pack to use a consistent formatter and field sets, supports lists and single instances, also supports 1-level deep field mapping to the dictionary. Also added new actions, list_images, list_sizes.