chore(errorpages): disable branded error pages by default - #62
Merged
Conversation
Turn off the Traefik error-page wiring in both charts: - stackdome-agent-standalone: errorPages.enabled now defaults to false, so the Service, Middleware, and catch-all IngressRoute are no longer rendered. - stackdome-agent: drop the entrypoint middleware references and set the subchart flag to false. Both changes have to move together. A middleware reference that does not resolve fails every router on that entrypoint, so leaving the references in place while the Middleware is gone would take ingress down. The agent still listens on the error-pages port and the middleware-reference validator still renders, so re-enabling is a matter of flipping the two flags back and restoring the entrypoint references.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Turns off the Traefik branded error-page wiring in both charts.
stackdome-agent-standalone:errorPages.enableddefaults tofalse, so the Service, Middleware, and catch-all IngressRoute are no longer rendered.stackdome-agent: drops thetraefik.ports.{web,websecure}.middlewaresreferences and sets the subchart flag tofalse.Both changes have to move together. Traefik fails every router whose middleware does not resolve, so leaving the entrypoint references in place while the Middleware is gone would take cluster ingress down.
What was left alone
templates/validate-error-page-middleware.yamlstill renders — it no-ops when no reference namesstackdome-errors.Re-enabling is flipping the two flags back and restoring the entrypoint references to
<release-namespace>-stackdome-errors@kubernetescrd.Test plan
helm template charts/stackdome-agent-standalone— no error-page Service/Middleware/IngressRoute in the output (only the port comment on the Deployment remains).helm lint charts/stackdome-agent-standalone— passes.