Fix stale release signals: port dial filter + releaseId on failure details - #64
Merged
Conversation
…er declares The stored PortCheck can belong to the previous revision — the checker only re-dials once the new pods run. A release that removed a port inherited its failing dial: the summary said "port 80 not accepting connections" for a spec that no longer declares port 80, and the hub put that on the new release's timeline. deployingDetail now filters the failing dialed ports against the currently declared spec ports and falls through to the rollout detail when none remain. Claude-Session: https://claude.ai/code/session_01TpRLszVTJudSd86RreufSC
LastFailureDetail and LastBuildFailureDetail gain releaseId, copied from the owning CR's release-id annotation at capture time: - workload crash capture (deployment path and the shared statefulset/job/cronjob path) - image build failure detail A lingering detail from a previous release keeps that release's ID, so the hub can drop it instead of showing it on the current release's timeline — the same release-id key the hub already gates build and resource events on. Claude-Session: https://claude.ai/code/session_01TpRLszVTJudSd86RreufSC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes for previous-release signals leaking onto the current release's timeline in the hub:
Stale port dial: the stored
PortCheckcan belong to the previous revision (the checker only re-dials once new pods run). A release that removed a port inherited its failing dial — the summary reported "port 80 not accepting connections" for a spec that no longer declares port 80.deployingDetailnow filters failing dialed ports against the currently declared spec ports and falls through to the rollout detail when none remain.releaseIdon failure details:LastFailureDetail/LastBuildFailureDetailgain an optionalreleaseId, stamped from the owning CR's release-id annotation at capture time (workload crash capture on both the deployment and statefulset/job/cronjob paths, and image build failure detail). A lingering detail from a previous release keeps that release's ID, so the hub can drop it instead of attributing it to the current release — the same release-id key the hub already gates build and resource events on.CRDs regenerated (stackresources + imagebuilds, charts and deploy copies). Additive optional field, no schema break.
Test plan
make testgreen (full suite incl. manifests/generate/fmt/vet)TestSummaryIgnoresDialForRemovedPort; existing dial specs now declare their port in spechttps://claude.ai/code/session_01TpRLszVTJudSd86RreufSC