fix(DSO-26715): bump js-yaml override to 3.15.2 - #121
Merged
Conversation
Co-authored-by: opencode <opencode@noreply.opencode.ai> Co-authored-by: GitHub Copilot <copilot@noreply.github.com>
Staffbase AI Code ReviewVerdict: ✅ Approved
FindingsNo findings. Bot commands
You can also resolve a non-critical inline conversation to ignore it (and unresolve to bring it back). Resolving a To bypass the entire review (criticals included), apply the Execution Steps (3)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://mitarbeiterapp.atlassian.net/browse/DSO-26715
What has been done?
js-yamlnpm override inpackage.jsonto3.15.2; regeneratedpackage-lock.json(3.15.0 -> 3.15.2).Why was this done?
@istanbuljs/load-nyc-config(^3.13.1, jest coverage chain), so the v3-range override is kept and just moved to the fixed version.How to test the changes?
npm installresolves cleanly, lockfile shows js-yaml 3.15.2 onlynpm run lintpasses;npm testgreen (6 suites, 158 tests)