Skip to content

GpsFolders: bump pin to v1.6.4 (fixes GPS-description crash) - #153

Merged
StarCpt merged 1 commit into
StarCpt:mainfrom
jgz:gpsfolders-v1.6.4
Aug 4, 2026
Merged

GpsFolders: bump pin to v1.6.4 (fixes GPS-description crash)#153
StarCpt merged 1 commit into
StarCpt:mainfrom
jgz:gpsfolders-v1.6.4

Conversation

@jgz

@jgz jgz commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Bumps the GpsFolders pin from 15cbe11 (v1.6.3, 2026-05-26) to 1376a89 (v1.6.4, 2026-07-31).

v1.6.4 is "Fix crash on changing gps desc then selecting a folder row", but the hub still points at
v1.6.3, so no client can receive it.

The crash it fixes

Reproduced three times on Pulsar v2.3.1 / SE 1.210.12. Adding a GPS folder after touching a GPS
description hard-crashes the client. Identical stack every time:

System.IndexOutOfRangeException: Index was outside the bounds of the array.
   at System.Text.StringBuilder.get_Chars(Int32 index)
   at System.Text.StringBuilderExtensions_Format.AppendSubstring(StringBuilder stringBuilder, StringBuilder append, Int32 start, Int32 count)
   at Sandbox.Graphics.GUI.MyGuiControlMultilineEditableText.GetCarriageOffset(Int32 idx)
   at Sandbox.Graphics.GUI.MyGuiControlMultilineText.Draw(Single transitionAlpha, Single backgroundTransitionAlpha)
   at Sandbox.Graphics.GUI.MyGuiScreenBase.Draw()
   at Sandbox.Graphics.GUI.MyGuiSandbox.Draw()
   at Sandbox.MySandboxGame.PrepareForDraw()

It's a draw-time exception, so there's no recovery — the client dies immediately. The folder write
itself succeeds first, so the change is present after restarting, which makes it look intermittent.

Clearing the Pulsar plugin cache doesn't help, since the re-download resolves to the pinned commit.

Verification

1376a89f3e1d86659e272ff35c43edb207e5138f is the current tip of master on StarCpt/SE-GpsFolders.
No other field changed.

Picks up 'v1.6.4: Fix crash on changing gps desc then selecting a folder
row'. The hub still pinned 15cbe11 (v1.6.3), so clients cannot receive
the fix.
@StarCpt

StarCpt commented Aug 4, 2026

Copy link
Copy Markdown
Owner

oops, I forgot to update the pluginhub xml. will merge

@StarCpt
StarCpt merged commit 3661744 into StarCpt:main Aug 4, 2026
1 check passed
@jgz
jgz deleted the gpsfolders-v1.6.4 branch August 4, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants