[BugFix] Fix result queue capacity of result sink #59153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zihe.liu <ziheliu1024@gmail.com>
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 3 / 3 (100.00%) file detail
|
alvin-celerdata
approved these changes
May 20, 2025
Contributor
alvin-celerdata
left a comment
alvin-celerdata
left a comment
There was a problem hiding this comment.
LGTM
Could you elaborate a little more on the influence of query in the commit message? Will the performance be influenced?
I'm not very sure about the consequence of one slot in the buffer.
Contributor
Author
|
@alvin-celerdata Added a performance test in the description. |
kangkaisen
approved these changes
May 22, 2025
satanson
approved these changes
May 22, 2025
|
@Mergifyio backport branch-3.3 |
|
@Mergifyio backport branch-3.5 |
|
@Mergifyio backport branch-3.4 |
Contributor
✅ Backports have been createdDetails
|
Contributor
✅ Backports have been createdDetails
|
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
May 22, 2025
Signed-off-by: zihe.liu <ziheliu1024@gmail.com> (cherry picked from commit 0ccc306) # Conflicts: # be/src/exec/data_sink.cpp
mergify bot
pushed a commit
that referenced
this pull request
May 22, 2025
Signed-off-by: zihe.liu <ziheliu1024@gmail.com> (cherry picked from commit 0ccc306)
mergify bot
pushed a commit
that referenced
this pull request
May 22, 2025
Signed-off-by: zihe.liu <ziheliu1024@gmail.com> (cherry picked from commit 0ccc306)
This was referenced May 22, 2025
wanpengfei-git
pushed a commit
that referenced
this pull request
May 22, 2025
wanpengfei-git
pushed a commit
that referenced
this pull request
May 22, 2025
wanpengfei-git
pushed a commit
that referenced
this pull request
Jun 9, 2025
AntiTopQuark
pushed a commit
to AntiTopQuark/starrocks
that referenced
this pull request
Jun 19, 2025
Signed-off-by: zihe.liu <ziheliu1024@gmail.com> Signed-off-by: AntiTopQuark <AntiTopQuark1350@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Introduced by #30386.
The result queue capacity is
dop*2.However, this dop is get by
state->query_options().pipeline_dop, which is the raw value of the session variablepipeline_dop(0 by default).This results that the queue capacity is 0, which means the queue will be full after putting one result batch. And therefore, result sink can only buffer one chunk.
Test
16Core 64GB Memory BE.
ResultDeliverTime:
ResultDeliverTime is decreased, but the total execution time between these two versions are the same.
What I'm doing:
Use actual DOP to set queue capacity.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: