[BugFix] Support Fast Schema Evolution v2 for DELETE in shared-data #67456
Merged
xiangguangyxg merged 2 commits intoStarRocks:mainfrom Jan 14, 2026
Merged
[BugFix] Support Fast Schema Evolution v2 for DELETE in shared-data #67456xiangguangyxg merged 2 commits intoStarRocks:mainfrom
xiangguangyxg merged 2 commits intoStarRocks:mainfrom
Conversation
dd0b4d7 to
e183c25
Compare
Contributor
|
@cursor review |
xiangguangyxg
previously approved these changes
Jan 6, 2026
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
e183c25 to
afbb402
Compare
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
|
Contributor
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Contributor
[FE Incremental Coverage Report]✅ pass : 8 / 8 (100.00%) file detail
|
Contributor
[BE Incremental Coverage Report]✅ pass : 5 / 5 (100.00%) file detail
|
Contributor
|
@cursor review |
xiangguangyxg
approved these changes
Jan 8, 2026
wyb
approved these changes
Jan 14, 2026
Contributor
|
@Mergifyio backport branch-4.0 |
Contributor
✅ Backports have been createdDetails
|
24 tasks
banmoy
added a commit
to banmoy/starrocks
that referenced
this pull request
Jan 14, 2026
…tarRocks#67456) Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
24 tasks
banmoy
added a commit
to banmoy/starrocks
that referenced
this pull request
Jan 14, 2026
…tarRocks#67456) Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy
added a commit
to banmoy/starrocks
that referenced
this pull request
Jan 14, 2026
…tarRocks#67456) Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
farhad-celo
pushed a commit
to farhad-celo/starrocks
that referenced
this pull request
Jan 20, 2026
…tarRocks#67456) Signed-off-by: PengFei Li <lpengfei2016@gmail.com> Signed-off-by: Farhad Shahmohammadi <f.shahmohammadi@celonis.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Why I'm doing:
DELETE needs to carry the table schema identity so BE can reliably interpret delete predicates under fast schema evolution v2, and update tablet metadata schema during publish when required.
What I'm doing:
schema_keytoDeleteDataRequest(proto) to identify the table schema used to generate the delete predicateTableSchemaKeyPBfrom db/table/base-index schema id inDeleteMgr, plumb it throughLakeDeleteJob, and attach it to the delete RPC requestschema_keyinLakeServiceImpl::delete_dataand persist it into the txn log viaTablet::delete_data(...)Fixes #65706
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
Note
Enables DELETE to carry the table schema identity for fast schema evolution v2 while remaining backward compatible.
schema_keytoDeleteDataRequestinlake_service.protoTableSchemaKeyPBinDeleteMgr, plumb throughLakeDeleteJob, and set on DELETE RPCschema_keyinLakeServiceImpl::delete_dataand pass toTablet::delete_data(...)Tablet::delete_datato persistschema_keyintoop_writetxn logschema_key) and FE unit test verifying request carries expectedschema_keyWritten by Cursor Bugbot for commit 01ac897. This will update automatically on new commits. Configure here.