[Enhancement] Restore missing optimizations in DP statistics estimation

[stephen-shelby]

Why I'm doing:

Recent changes on main unintentionally dropped some performance optimizations in the DP statistics estimation hot path. Since DP join reorder calls calculateStatistics() thousands of times, the regression is amplified. This PR restores those missing optimizations to bring performance back while keeping cost/statistics semantics unchanged.

What I'm doing:

• Restore the guard for PredicateColumnsMgr.recordJoinPredicate(...) under skipPredicateColumnsCollectionScope() to avoid repeated predicate-columns recording during DP stats estimation.
• Restore the rowcount-only fast path in correlated join estimation by using withOutputRowCount(...) instead of rebuilding Statistics via buildFrom(...).build().
• Restore the optimized adjustStatisticsByRowCount() fast path:
  • update rowcount via withOutputRowCount first,
  • avoid stream/lambda overhead with loops and early breaks,
  • rebuild column stats only when NDV adjustment is actually needed.

Fixes #issue

What type of PR is this:

• BugFix
• Feature
• Enhancement
• Refactor
• UT
• Doc
• Tool

Does this PR entail a change in behavior?

• Yes, this PR will result in a change in behavior.
• No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

• Interface/UI changes: syntax, type conversion, expression evaluation, display information
• Parameter changes: default values, similar parameters but with different default values
• Policy changes: use new policy to replace old one, functionality automatically enabled
• Feature removed
• Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

• I have added test cases for my bug fix or my new feature
• This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function
  • This pr needs auto generate documentation
• This is a backport pr

Bugfix cherry-pick branch check:

• I have checked the version labels which the pr will be auto-backported to the target branch
  • 4.1
  • 4.0
  • 3.5
  • 3.4

---

Note

Restores missing performance optimizations in DP stats estimation hot path without altering cost/statistics semantics.

• Guard PredicateColumnsMgr.recordJoinPredicate(...) with shouldSkipPredicateColumnsCollection() to avoid repeated recording during DP estimation
• Use withOutputRowCount(...) in correlated inner-join estimation instead of rebuilding Statistics
• Optimize StatisticsEstimateUtils.adjustStatisticsByRowCount(...):
  • update rowcount via withOutputRowCount first
  • early-return if table row count is inaccurate or any column stats are unknown
  • loop with early-break to decide NDV adjustment and rebuild only when needed

^{Written by Cursor Bugbot for commit 2659684. This will update automatically on new commits. Configure here.}

[StarRocks-Reviewer]

@cursor review

[cursor]

✅ Bugbot reviewed your changes and found no bugs!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

[github-actions]

[FE Incremental Coverage Report]

✅ pass : 24 / 24 (100.00%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/sql/optimizer/statistics/StatisticsEstimateUtils.java	18	18	100.00%	[]
🔵	com/starrocks/sql/optimizer/statistics/StatisticsCalculator.java	6	6	100.00%	[]

[github-actions]

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

[alvin-celerdata]

@cursor review

[github-actions]

@Mergifyio backport branch-4.1

[github-actions]

@Mergifyio backport branch-4.0

[mergify]

backport branch-4.1

❌ No backport have been created

Details

• Backport to branch branch-4.1 failed

GitHub error: Branch not found

[mergify]

backport branch-4.0

✅ Backports have been created

Details

• #67921 [Enhancement] Restore missing optimizations in DP statistics estimation (backport #67852) has been created for branch branch-4.0