[BugFix] Fixed bad path regex to work with legal simple json paths

[brent-statsig]

Why I'm doing:

I have JSON keys that contain the characters -. While looking at profiles, I noticed that queries for those keys aren't properly pushing down their filter predicates. This regex prevents the FE from considering this a valid column access expression, which then causes the significantly less performant jsonMerge to run, causing a pretty significant performance regression to all queries accessing these keys.

What I'm doing:

Added the - character I use on a regular basis to the regex.

I noticed in the be code paths, this is the regex that is used, plus one that was commented out? It is unclear to me if there is a better option, but this is what I saw: link to code

// static const re2::RE2 JSON_PATTERN("^([a-zA-Z0-9_\\-\\:\\s#\\|\\.]*)(?:\\[([0-9]+)\\])?");
// json path cannot contains: ", [, ]
const re2::RE2 SIMPLE_JSONPATH_PATTERN(R"(^([^\"\[\]]*)(?:\[([0-9]+|\*)\])?)", re2::RE2::Quiet);

What type of PR is this:

• BugFix
• Feature
• Enhancement
• Refactor
• UT
• Doc
• Tool

Does this PR entail a change in behavior?

• Yes, this PR will result in a change in behavior.
• No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

• Interface/UI changes: syntax, type conversion, expression evaluation, display information
• Parameter changes: default values, similar parameters but with different default values
• Policy changes: use new policy to replace old one, functionality automatically enabled
• Feature removed
• Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

• I have added test cases for my bug fix or my new feature
• This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function
  • This pr needs auto generate documentation
• This is a backport pr

Bugfix cherry-pick branch check:

• I have checked the version labels which the pr will be auto-backported to the target branch
  • 4.1
  • 4.0
  • 3.5
  • 3.4

---

Note

Updates JsonPathRewriteRule to broaden simple JSON path validation from ^[a-zA-Z0-9_]+$ to ^[a-zA-Z0-9\-_]+$.

• Enables rewrite of JSON functions when field names include hyphens, improving predicate/projection pushdown on JSON columns

^{Written by Cursor Bugbot for commit d1e6084. This will update automatically on new commits. Configure here.}

[CLAassistant]

All committers have signed the CLA.

[alvin-celerdata]

@cursor review

[cursor]

✅ Bugbot reviewed your changes and found no bugs!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[brent-statsig]

Actually - I think I need to include more things. I noticed I query the json path $.custom."k8s.container.status.last_terminated_reason". According to spec, basically anything in quotes is ~legal, and the current code doesn't really validate the difference between quotes and unquoted paths.

I don't know nearly enough about what is supported for JSON path though, so I'm a bit apprehensive to keep just adding characters and hope something doesn't break. Can someone with more knowledge take a look and make a recommendation?

[github-actions]

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

[github-actions]

[FE Incremental Coverage Report]

✅ pass : 1 / 1 (100.00%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/sql/optimizer/rule/tree/JsonPathRewriteRule.java	1	1	100.00%	[]

[github-actions]

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

[github-actions]

@Mergifyio backport branch-4.1

[github-actions]

@Mergifyio backport branch-4.0

[github-actions]

@Mergifyio backport branch-3.5

[mergify]

backport branch-4.1

✅ Backports have been created

Details

• #68218 [BugFix] Fixed bad path regex to work with legal simple json paths (backport #67988) has been created for branch branch-4.1

[mergify]

backport branch-4.0

✅ Backports have been created

Details

• #68219 [BugFix] Fixed bad path regex to work with legal simple json paths (backport #67988) has been created for branch branch-4.0

[mergify]

backport branch-3.5

✅ Backports have been created

Details

• #68220 [BugFix] Fixed bad path regex to work with legal simple json paths (backport #67988) has been created for branch branch-3.5 but encountered conflicts

Cherry-pick of 62ce106 has failed:

On branch mergify/bp/branch-3.5/pr-67988
Your branch is up to date with 'origin/branch-3.5'.

You are currently cherry-picking commit 62ce106137.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/tree/JsonPathRewriteRule.java

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally