[BugFix] Add TYPE_DECIMAL256 support for column aggregators in PRIMARY KEY tables#68134
Merged
andyziye merged 1 commit intoStarRocks:mainfrom Jan 21, 2026
Merged
Conversation
…Y KEY tables Signed-off-by: stephen <stephen5217@163.com>
|
@cursor review |
Contributor
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Contributor
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Contributor
[BE Incremental Coverage Report]❌ fail : 0 / 2 (00.00%) file detail
|
ZiheLiu
approved these changes
Jan 20, 2026
wyb
approved these changes
Jan 20, 2026
Contributor
|
@Mergifyio backport branch-4.0 |
Contributor
|
@Mergifyio backport branch-4.1 |
Contributor
✅ Backports have been createdDetails
|
Contributor
✅ Backports have been createdDetails
|
24 tasks
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
When using DECIMAL columns with precision > 38 (e.g., DECIMAL(39,0)) in PRIMARY KEY tables, the backend crashes during data insertion:
The column aggregator factory doesn't support
TYPE_DECIMAL256(type ID 26), which is required for decimal precision between 39-76.What I'm doing:
Backend fix (
be/src/storage/column_aggregate_func.cpp):TYPE_DECIMAL256support for REPLACE aggregation (line 380)TYPE_DECIMAL256support for key column aggregation (line 427)Fixes #67991
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: