[BugFix] Prevent aggregate pushdown when group keys involve JSON type by stephen-shelby · Pull Request #68142 · StarRocks/starrocks

stephen-shelby · 2026-01-20T03:49:29Z

Why I'm doing:

Aggregate pushdown may rewrite DISTINCT/group-by expressions to their used columns when pushing below Project/Join.
For expressions that depend on a JSON column, this can end up pushing down an aggregate that groups by a JSON column, which is not supported in BE and fails at runtime with:
group by type JSON is not supported backend.

What I'm doing:

Add a safety check in PushDownAggregateCollector to block aggregate pushdown when any group-key used column type cannot be grouped in BE (e.g. JSON).

Fixes #issue

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function
- This pr needs auto generate documentation
This is a backport pr

Bugfix cherry-pick branch check:

Signed-off-by: stephen <stephen5217@163.com>

StarRocks-Reviewer · 2026-01-20T03:56:24Z

@cursor review

sonarqubecloud · 2026-01-20T04:04:35Z

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2026-01-20T05:08:40Z

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2026-01-20T05:10:10Z

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2026-01-20T05:10:18Z

[FE Incremental Coverage Report]

✅ pass : 4 / 4 (100.00%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/sql/optimizer/rule/tree/pdagg/PushDownAggregateCollector.java	4	4	100.00%	[]

...re/src/main/java/com/starrocks/sql/optimizer/rule/tree/pdagg/PushDownAggregateCollector.java

github-actions · 2026-01-21T02:32:56Z

@Mergifyio backport branch-3.5

github-actions · 2026-01-21T02:32:57Z

@Mergifyio backport branch-4.0

github-actions · 2026-01-21T02:32:57Z

@Mergifyio backport branch-4.1

mergify · 2026-01-21T02:33:02Z

backport branch-3.5

✅ Backports have been created

Details

#68196 [BugFix] Prevent aggregate pushdown when group keys involve JSON type (backport #68142) has been created for branch branch-3.5

mergify · 2026-01-21T02:33:02Z

backport branch-4.0

✅ Backports have been created

Details

#68197 [BugFix] Prevent aggregate pushdown when group keys involve JSON type (backport #68142) has been created for branch branch-4.0

mergify · 2026-01-21T02:33:03Z

backport branch-4.1

✅ Backports have been created

Details

#68198 [BugFix] Prevent aggregate pushdown when group keys involve JSON type (backport #68142) has been created for branch branch-4.1

…#68142) Signed-off-by: stephen <stephen5217@163.com> (cherry picked from commit 8e40076)

… (backport #68142) (#68197) Signed-off-by: stephen <stephen5217@163.com> Co-authored-by: stephen <91597003+stephen-shelby@users.noreply.github.com>

… (backport #68142) (#68198) Signed-off-by: stephen <stephen5217@163.com> Co-authored-by: stephen <91597003+stephen-shelby@users.noreply.github.com>

… (backport #68142) (#68196) Signed-off-by: stephen <stephen5217@163.com> Co-authored-by: stephen <91597003+stephen-shelby@users.noreply.github.com>

[BugFix] Prevent aggregate pushdown when group keys involve JSON type

7bd6f8a

Signed-off-by: stephen <stephen5217@163.com>

stephen-shelby requested a review from a team as a code owner January 20, 2026 03:49

stephen-shelby changed the title ~~[BugFix] Prevent aggregate pushdown when group keys involve JSON type~~ [UT] Prevent aggregate pushdown when group keys involve JSON type Jan 20, 2026

mergify bot assigned stephen-shelby Jan 20, 2026

github-actions bot added 3.5 4.0 4.1 labels Jan 20, 2026

stephen-shelby changed the title ~~[UT] Prevent aggregate pushdown when group keys involve JSON type~~ [BugFix] Prevent aggregate pushdown when group keys involve JSON type Jan 20, 2026

kangkaisen reviewed Jan 20, 2026

View reviewed changes

...re/src/main/java/com/starrocks/sql/optimizer/rule/tree/pdagg/PushDownAggregateCollector.java Show resolved Hide resolved

kangkaisen approved these changes Jan 21, 2026

View reviewed changes

Seaven approved these changes Jan 21, 2026

View reviewed changes

stephen-shelby merged commit 8e40076 into StarRocks:main Jan 21, 2026
101 of 113 checks passed

github-actions bot removed 3.5 4.0 4.1 labels Jan 21, 2026

mergify bot pushed a commit that referenced this pull request Jan 21, 2026

[BugFix] Prevent aggregate pushdown when group keys involve JSON type (…

2471cd3

…#68142) Signed-off-by: stephen <stephen5217@163.com> (cherry picked from commit 8e40076)

mergify bot mentioned this pull request Jan 21, 2026

[BugFix] Prevent aggregate pushdown when group keys involve JSON type (backport #68142) #68196

Merged

24 tasks

mergify bot pushed a commit that referenced this pull request Jan 21, 2026

[BugFix] Prevent aggregate pushdown when group keys involve JSON type (…

6732498

…#68142) Signed-off-by: stephen <stephen5217@163.com> (cherry picked from commit 8e40076)

mergify bot mentioned this pull request Jan 21, 2026

[BugFix] Prevent aggregate pushdown when group keys involve JSON type (backport #68142) #68197

Merged

24 tasks

mergify bot pushed a commit that referenced this pull request Jan 21, 2026

[BugFix] Prevent aggregate pushdown when group keys involve JSON type (…

3b89d3f

…#68142) Signed-off-by: stephen <stephen5217@163.com> (cherry picked from commit 8e40076)

mergify bot mentioned this pull request Jan 21, 2026

[BugFix] Prevent aggregate pushdown when group keys involve JSON type (backport #68142) #68198

Merged

24 tasks

github-actions bot added the 4.0-merged label Jan 21, 2026

github-actions bot added the 4.1-merged label Jan 21, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BugFix] Prevent aggregate pushdown when group keys involve JSON type#68142

[BugFix] Prevent aggregate pushdown when group keys involve JSON type#68142
stephen-shelby merged 1 commit intoStarRocks:mainfrom
stephen-shelby:fix_json_push_agg

stephen-shelby commented Jan 20, 2026 •

edited

Loading

Uh oh!

StarRocks-Reviewer commented Jan 20, 2026

Uh oh!

sonarqubecloud bot commented Jan 20, 2026

Uh oh!

github-actions bot commented Jan 20, 2026

Uh oh!

github-actions bot commented Jan 20, 2026

Uh oh!

github-actions bot commented Jan 20, 2026

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 21, 2026

Uh oh!

github-actions bot commented Jan 21, 2026

Uh oh!

github-actions bot commented Jan 21, 2026

Uh oh!

mergify bot commented Jan 21, 2026 •

edited

Loading

Uh oh!

mergify bot commented Jan 21, 2026 •

edited

Loading

Uh oh!

mergify bot commented Jan 21, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

stephen-shelby commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why I'm doing:

What I'm doing:

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

Uh oh!

StarRocks-Reviewer commented Jan 20, 2026

Uh oh!

sonarqubecloud bot commented Jan 20, 2026

Quality Gate passed

Uh oh!

github-actions bot commented Jan 20, 2026

[Java-Extensions Incremental Coverage Report]

Uh oh!

github-actions bot commented Jan 20, 2026

[BE Incremental Coverage Report]

Uh oh!

github-actions bot commented Jan 20, 2026

[FE Incremental Coverage Report]

file detail

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 21, 2026

Uh oh!

github-actions bot commented Jan 21, 2026

Uh oh!

github-actions bot commented Jan 21, 2026

Uh oh!

mergify bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

mergify bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

mergify bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

stephen-shelby commented Jan 20, 2026 •

edited

Loading

mergify bot commented Jan 21, 2026 •

edited

Loading

mergify bot commented Jan 21, 2026 •

edited

Loading

mergify bot commented Jan 21, 2026 •

edited

Loading