Skip to content

fix(ci): handle large PR diffs in golangci-lint#522

Merged
Starosdev merged 12 commits into
masterfrom
develop
May 18, 2026
Merged

fix(ci): handle large PR diffs in golangci-lint#522
Starosdev merged 12 commits into
masterfrom
develop

Conversation

@Starosdev
Copy link
Copy Markdown
Owner

@Starosdev Starosdev commented May 18, 2026

Summary

  • Fix golangci-lint CI failure on large PRs (develop->master with >20k line diffs). Switches from only-new-issues: true (GitHub API diff fetch, fails at 20k lines) to --new-from-rev=origin/${{ github.base_ref }} (git-based, no limit)
  • Fix ST1005 staticcheck: lowercase error string in attachDeviceEnduranceOverrides
  • Fix rangeValCopy: use index-based range in attachDeviceEnduranceOverrides to avoid copying 416-byte struct

Note: TBW tracking and frontend lint debt reduction (originally in this PR) were already released in v1.56.0.

Test plan

  • CI passes (lint no longer fails on large develop->master diff)

@Starosdev Starosdev added the enhancement New feature or request label May 18, 2026
Starosdev added 2 commits May 17, 2026 20:45
Switch golangci-lint from only-new-issues (GitHub API) to --new-from-rev
(git) to avoid 406 errors when PR diff exceeds 20k lines. Also fix
rangeValCopy in attachDeviceEnduranceOverrides.
@Starosdev Starosdev merged commit 05e6cb3 into master May 18, 2026
21 checks passed
Starosdev pushed a commit that referenced this pull request May 18, 2026
## [1.56.0](v1.55.1...v1.56.0) (2026-05-18)

### Features

* add array size and used device size metrics to mdadm collector and frontend UI ([6454b12](6454b12))
* add debug and error logging to mdadm repository query methods ([b591988](b591988))
* add dynamic mdadm array status styling and sync progress visualization to dashboard ([1525601](1525601))
* add dynamic status display, sync progress, and improved empty state handling for MDADM details ([4880422](4880422))
* add manual collector trigger capability to dashboard and backend API ([95544aa](95544aa))
* add MDADM array state and sync progress monitoring to UI and backend summary endpoint ([ab719c4](ab719c4))
* add MDADM recovery progress tracking and dedicated endpoint for latest metrics retrieval ([c799868](c799868))
* add support for MDADM RAID array monitoring and reporting ([fdd4ad5](fdd4ad5))
* add support for MDADM RAID array monitoring and visualization ([e618932](e618932))
* add udev, dev, and mdstat volume mounts to support MDADM monitoring ([08ed2c6](08ed2c6))
* capture and display raw /proc/mdstat output for mdadm arrays ([ee1da6c](ee1da6c))
* **frontend:** add 12-hour / 24-hour time format preference ([#445](#445)) ([ea174dc](ea174dc))
* implement dynamic mdstat path resolution to support containerized environments ([cf72f27](cf72f27))
* implement filesystem summary dashboard widgets and backend repository support ([8568995](8568995))
* implement registration filtering for mdadm array metrics upload ([bf0eaf5](bf0eaf5))
* import MatProgressSpinnerModule into dashboard module ([e419cd7](e419cd7))
* integrate notification gate for MDADM metric uploads and update mock database methods ([7a946c9](7a946c9))
* parse sync progress from /proc/mdstat when mdadm detail is unavailable ([4ef70e0](4ef70e0))
* support float progress percentages for mdadm, add group to influx query, and include database test utility ([722364c](722364c))
* **workload:** add rated TBW tracking and reduce frontend lint debt ([#522](#522)) ([05e6cb3](05e6cb3)), closes [#460](#460) [#517](#517) [#520](#520)

### Bug Fixes

* add sudo support for mdadm commands and use raw UUID in API endpoint path ([953fc14](953fc14))
* **backend:** address potential memory leak sources ([#419](#419)) ([#426](#426)) ([1fa8906](1fa8906))
* **ci:** harden release notes script against edge cases ([8374e99](8374e99))
* **ci:** include develop-to-master integration PRs in release notes ([0c01c77](0c01c77))
* **ci:** match v1.48.0 release note format (dash list, hyperlinked closes, no separators) ([acc14c3](acc14c3))
* **ci:** use --slurpfile to avoid ARG_MAX error in release notes script ([38ddb0b](38ddb0b))
* **database:** handle missing device_wwn column in summary query ([#423](#423)) ([8fe85a0](8fe85a0))
* **database:** handle missing device_wwn column in summary query ([#423](#423)) ([4359719](4359719))
* **frontend:** temperature chart tooltip truncation and spike hover ([#443](#443)) ([1742a4d](1742a4d))
* handle null history and update InfluxDB queries to preserve string fields using schema.fieldsAsCols ([7753c49](7753c49))
* handle zero-value used_bytes in UI and improve RAID mount point detection for partitioned devices ([01e3b39](01e3b39))
* **mdadm:** close PR 474 merge blockers ([046bbe8](046bbe8))
* **notify:** auto-add disabletls=Yes for Gotify URLs on HTTP ports ([#472](#472)) ([79c2cc9](79c2cc9))
* remove scrutiny-collector-performance from manual collector run list ([68bf0c7](68bf0c7))
* **settings:** block override submission for remaining 400 cases ([#476](#476)) ([#480](#480)) ([40a8a66](40a8a66))
* **settings:** prevent 400 error when adding attribute overrides ([3db7ffb](3db7ffb)), closes [#476](#476)
* **settings:** widen settings dialog to prevent content cutoff ([#475](#475)) ([63acac4](63acac4))
* **uptime-kuma:** add insecure_skip_verify option for self-signed TLS certs ([#418](#418)) ([b76923d](b76923d))
* **uptime-kuma:** add nolint directive for gosec G402 on InsecureSkipVerify ([52c53f0](52c53f0))
* **uptime-kuma:** always set TLS transport to satisfy gosec G402 lint ([6b4fe54](6b4fe54))
* **uptime-kuma:** use variable for InsecureSkipVerify to satisfy gosec G402 ([a1e56ff](a1e56ff))

### Refactoring

* move getMountUsage to build-tagged files for cross-platform support ([dd9c410](dd9c410))
* remove parameterized InfluxDB queries in favor of direct string formatting for MDADM metrics ([3b53070](3b53070))
* replace lsblk usage detection with direct mount point lookup via /proc/self/mountinfo ([f2c90b4](f2c90b4))
* replace mount-based usage detection with lsblk JSON output for improved container compatibility ([4d5647c](4d5647c))
* replace UsedDevSize with filesystem-level UsedBytes metric for mdadm arrays ([c88f5c3](c88f5c3))
@Starosdev Starosdev changed the title feat(workload): add rated TBW tracking and reduce frontend lint debt fix(ci): handle large PR diffs in golangci-lint May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant