fix(deps): bump engine.io and ws overrides on develop - #802
Merged
Conversation
Dependabot's engine.io security PR targets master, which tracks upstream AnalogJ/scrutiny, so it is closed rather than merged and develop keeps resolving the vulnerable versions. Pin the fixed versions through the frontend override block instead, which is how the other transitive security pins in this file are already handled. engine.io moves to 6.6.9, closing GHSA-gr94-w7qr-f4j3 (affects >= 6.5.0, < 6.6.7). ws moves to 8.21.3, closing GHSA-96hv-2xvq-fx4p (affects >= 8.0.0, < 8.21.0); the previous 8.20.1 pin predates that advisory. Both are dev-only transitive dependencies of karma, so no shipped artifact changes. The ws override stays necessary after the engine.io bump because socket.io-adapter still requests ~8.17.1. Test plan: - npm ci - npx ng test --watch=false --browsers=ChromeHeadless --code-coverage (191/191 pass) - npm audit --package-lock-only no longer reports engine.io or ws
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #741
Summary
developstill resolvedengine.io6.6.4 andws8.20.1, both covered by open Dependabot alerts. Dependabot's own fix PRs (#669, and now #781) targetmaster, which tracks upstream AnalogJ/scrutiny, so they get closed rather than merged anddevelopnever moves.Pin the fixed versions through the frontend
overridesblock, which is already how the other transitive security pins in this file are handled (postcss,qs,socket.io-parser, andwsitself).engine.io6.6.4 to 6.6.9, closing GHSA-gr94-w7qr-f4j3 (affects>= 6.5.0, < 6.6.7, high).ws8.20.1 to 8.21.3, closing GHSA-96hv-2xvq-fx4p (affects>= 8.0.0, < 8.21.0, the advisory the issue refers to). The existing 8.20.1 pin predates that advisory.Both are dev-only transitive dependencies of karma, so no shipped artifact changes.
The
wsoverride is still required after theengine.iobump:socket.io-adapterrequests~8.17.1independently, so without it npm resolves a nestedws8.17.1 that remains in the vulnerable range.Test plan
npm ciinwebapp/frontend(clean, lockfile in sync with package.json)npx ng test --watch=false --browsers=ChromeHeadless --code-coverage: 191/191 pass, which exercises karma's socket layer directlynpm audit --package-lock-onlyno longer listsengine.ioorwsFollow-ups (not in scope)
masterbecause security updates ignoretarget-branchand always open against the default branch. chore(deps): bump engine.io from 6.6.4 to 6.6.9 in /webapp/frontend #781 can be closed like chore(deps): bump engine.io from 6.6.4 to 6.6.9 in /webapp/frontend #669 once this merges.socket.io-parseris pinned at 4.2.6 and GHSA-2m8v-j782-fhvr covers< 4.2.7; that pin needs its own bump.