Skip to content

fix snpInfo bug and unnest - #566

Merged
danielnachun merged 2 commits into
mainfrom
snpinfo_unnest
Aug 5, 2026
Merged

fix snpInfo bug and unnest#566
danielnachun merged 2 commits into
mainfrom
snpinfo_unnest

Conversation

@danielnachun

Copy link
Copy Markdown
Collaborator

This PR will fix the issue where snpInfo wasn't subsetted correctly for regional sumstats. I've also rolled in another fix for nested functions which are not allowed in bioconductor

@danielnachun
danielnachun merged commit 03738ac into main Aug 5, 2026
7 checks passed
@danielnachun
danielnachun deleted the snpinfo_unnest branch August 5, 2026 00:31
@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.25480% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.18%. Comparing base (3796f49) to head (5fd27a4).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
R/sumstatsQc.R 95.45% 6 Missing ⚠️
R/fineMappingPipeline.R 96.33% 4 Missing ⚠️
R/fineMappingWrappers.R 96.33% 4 Missing ⚠️
R/h2EstimationWrappers.R 94.44% 2 Missing ⚠️
R/ld.R 98.64% 1 Missing ⚠️
R/qtlEnrichmentPipeline.R 94.73% 1 Missing ⚠️
R/twasWeightsPipeline.R 97.95% 1 Missing ⚠️
R/variantId.R 94.44% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #566   +/-   ##
=======================================
  Coverage   98.18%   98.18%           
=======================================
  Files          66       66           
  Lines       16982    17027   +45     
=======================================
+ Hits        16673    16718   +45     
  Misses        309      309           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant