Migrating Current Electron version to Stable Electron version#392
Migrating Current Electron version to Stable Electron version#392lrasmus merged 6 commits intoStatTag:masterfrom
Conversation
lrasmus
left a comment
There was a problem hiding this comment.
This overall seems to be working so far, but I'm confused where you got some of the version numbers that you used for the upgrade. 3 of the versions don't exist and were triggering warnings for me. Please confirm that any version number we use for a package exists.
| "electron-debug": "^3.0.1", | ||
| "electron-log": "^5.4.1", | ||
| "electron-updater": "^6.6.2", | ||
| "electron-log": "^5.5.0", |
There was a problem hiding this comment.
It appears the latest version of electron-log is 5.4.3? I'm getting a warning when running setup:
Couldn't find any versions for "electron-log" that matches "^5.5.0"
Although it prompts me to select the version I want to use, we should only include currently available versions.
There was a problem hiding this comment.
Yhh , These are not the valid version , I got list of version in terminal for these and selected from the list and didn't cross check if they are valid or not .
I had updated the dependencies
| "electron-log": "^5.4.1", | ||
| "electron-updater": "^6.6.2", | ||
| "electron-log": "^5.5.0", | ||
| "electron-updater": "^6.10.0", |
There was a problem hiding this comment.
Same as with electron-log, the latest electron-updater appears to be 6.8.3.
| "electron": "33.4.11", | ||
| "electron-builder": "^24.13.3", | ||
| "electron": "39.8.5", | ||
| "electron-builder": "^24.15.0", |
There was a problem hiding this comment.
There is no 24.15 of electron-builder. Do you know if this needs to work with the latest 24.* release, or can we upgrade to 26.*?
3d16876 to
88e36ca
Compare
Signed-off-by: Ayush <bhandariayush935@gmail.com>
Signed-off-by: Ayush <bhandariayush935@gmail.com>
Signed-off-by: Ayush <bhandariayush935@gmail.com>
Signed-off-by: Ayush <bhandariayush935@gmail.com>
f53aacf to
6de50b6
Compare
|
@lrasmus , |
lrasmus
left a comment
There was a problem hiding this comment.
Thank you so much, @Ayush4958!
Summary
Update the current electron version to higher stable version of electron.
Changes
main.dev.js, i had modernize the window creation process by using promise based approach as it's prefer in newer electron versionIn
package.json, I had updated electron version along with its ecosystem dependency (builder , rebuild , log , updater)and there is change in script of
start-main-dev, which is done as the older script giving error in main process .In
yarn.lockAuto-generated the latest dependency constraints strictly correlating with thepackage.jsonupgrade.Test
Already runs all the Test cases & It passes all in my end.