Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/main.dev.js
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,8 @@ app.on('window-all-closed', () => {
}
});

app.on('ready', createWindow);
// Modernize the window creation process as newer electron version strongly prefer promise based approach
app.whenReady().then(createWindow);

app.on('activate', () => {
// On macOS it's common to re-create a window in the app when the
Expand Down
12 changes: 6 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"preinstall": "node ./internals/scripts/CheckYarn.js",
"prestart": "yarn build",
"start": "cross-env NODE_ENV=production electron ./app/main.prod.js",
"start-main-dev": "cross-env START_HOT=1 NODE_ENV=development electron -r @babel/register ./app/main.dev.js",
"start-main-dev": "cross-env START_HOT=1 NODE_ENV=development NODE_OPTIONS=--no-experimental-detect-module electron -r @babel/register ./app/main.dev.js",
"start-renderer-dev": "cross-env NODE_ENV=development webpack-dev-server --config configs/webpack.config.renderer.dev.babel.js",
"start-worker-dev": "cross-env NODE_ENV=development webpack-dev-server --config configs/webpack.config.worker.dev.babel.js",
"test": "cross-env NODE_ENV=test BABEL_DISABLE_CACHE=1 jest",
Expand Down Expand Up @@ -176,8 +176,8 @@
"cross-spawn": "^7.0.5",
"css-loader": "^6.10.0",
"detect-port": "^1.3.0",
"electron": "33.4.11",
"electron-builder": "^24.13.3",
"electron": "39.8.5",
"electron-builder": "^26.8.2",
"electron-builder-notarize": "^1.5.2",
"electron-devtools-installer": "^3.2.0",
"eslint": "^9.29.0",
Expand Down Expand Up @@ -218,7 +218,7 @@
"yarn": "^1.22.22"
},
"dependencies": {
"@electron/rebuild": "^3.6.0",
"@electron/rebuild": "^3.7.0",
"@electron/remote": "^2.1.2",
"@emotion/react": "^11.14.0",
"@emotion/styled": "^11.14.0",
Expand All @@ -236,8 +236,8 @@
"echarts": "^5.6.0",
"echarts-for-react": "^3.0.2",
"electron-debug": "^3.0.1",
"electron-log": "^5.4.1",
"electron-updater": "^6.6.2",
"electron-log": "^5.4.3",
"electron-updater": "^6.8.3",
"flexsearch": "^0.8.205",
"github-markdown-css": "^5.8.1",
"history": "^5.3.0",
Expand Down
Loading