ci(devnet): put the two newest coverage classes in the default filter - #166
ci(devnet): put the two newest coverage classes in the default filter#166Platonenkov wants to merge 1 commit into
Conversation
TestIXChainAttestation and TestILoanMultisig were written after this workflow and never added to it. Between them they are the only traffic for both attestation transaction types, XChainClaim, and LoanSet.CounterpartySignature.Signers, so a default run covered none of that. Verified by dispatching with the corrected filter: 101 tests, 92 passed, 9 skipped for MPTokensV2 being absent from devnet, none failed.
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (1)
Included review availability: 3 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughThe devnet coverage workflow now documents execution constraints and runs ChangesDevnet coverage workflow
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The workflow now includes attestation and loan multisig coverage in its default devnet test filter. The supplied successful run and review evidence indicate no remaining merge-readiness risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Superseded by #167. The two filter entries from this branch are merged into that one, together with |
TestIXChainAttestationandTestILoanMultisigwere written afterdevnet-coverage.ymland never added to its default filter. Between them they are the only traffic for both attestation transaction types,XChainClaim, andLoanSet.CounterpartySignature.Signers, so a run left on the defaults covered none of that.The comment above the filter now says to keep it in step, and names what was missed.
Verified by dispatching the workflow with the corrected filter before this change landed: run 33823118083, 101 tests, 92 passed, 9 skipped because
MPTokensV2is not enabled on devnet, none failed. That run was also the first time this workflow executed in Actions at all:workflow_dispatchis read from the default branch, so it only became reachable once #165 merged.Summary by CodeRabbit