Add some more metrics to the output for thresholding#65
Merged
nowellclosser merged 1 commit intomainfrom Jan 25, 2026
Merged
Conversation
… float64 for JAX where possible, update tests for minor floating point discrepancies accordingly
nowellclosser
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of merely using the max eigenvalue of the joint bread matrix as a metric, divide it by the median of the eigenvalues above a certain nonzero threshold to produce a dimensionless metric.
More promisingly, outputs new metric that probes in 15 random directions on the order of 1/sqrt(n) and checks that the linearization of the joint estimating function using the bread matrix is valid.
Also enable float64 for JAX where possible, update tests for minor floating point discrepancies accordingly.